Changeset 50674 in webkit

Timestamp:

Nov 9, 2009 11:50:58 AM (14 years ago)

Author:

eric@webkit.org

Message:

2009-11-09 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Dimitri Glazkov.

Win chromium is slow to draw transparent texts
​https://bugs.webkit.org/show_bug.cgi?id=31258

Clip graphics context to reduce calculation.

No new tests because this change only affects performance.

• platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/chromium/FontChromiumWin.cpp (modified) (4 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-09  Shinichiro Hamaji  <hamaji@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Win chromium is slow to draw transparent texts
+        https://bugs.webkit.org/show_bug.cgi?id=31258
+
+        Clip graphics context to reduce calculation.
+
+        No new tests because this change only affects performance.
+
+        * platform/graphics/chromium/FontChromiumWin.cpp:
+        (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
+        (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
+
 2009-11-09  Carol Szabo  <carol.szabo@nokia.com>
 

trunk/WebCore/platform/graphics/chromium/FontChromiumWin.cpp

@@ -113 +113 @@
 void TransparencyAwareFontPainter::initializeForGDI()
 {
+    m_graphicsContext->save();
     SkColor color = m_platformContext->effectiveFillColor();
     if (SkColorGetA(color) != 0xFF) {
@@ -132 +133 @@
         layerMode = TransparencyWin::TextComposite;
         layerRect = estimateTextBounds();
+        m_graphicsContext->clip(layerRect);
 
         // The transparency helper requires that we draw text in black in
@@ -142 +144 @@
         layerMode = TransparencyWin::OpaqueCompositeLayer;
         layerRect = estimateTextBounds();
+        m_graphicsContext->clip(layerRect);
     } else {
         // Common case of drawing onto the bottom layer of a web page: we
@@ -168 +171 @@
     if (m_createdTransparencyLayer)
         m_graphicsContext->endTransparencyLayer();
+    m_graphicsContext->restore();
     m_platformContext->canvas()->endPlatformPaint();
 }