Changeset 50796 in webkit

Timestamp:

Nov 11, 2009 1:38:36 AM (15 years ago)

Author:

eric@webkit.org

Message:

2009-11-11 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Eric Seidel.

[Qt] Make the default style background color valid.
Currently the color is transparent but invalid, this causes
list boxes in QtWebKit to be drawn with a black background
since r49242.
​https://bugs.webkit.org/show_bug.cgi?id=31295

• rendering/style/RenderStyle.h: (WebCore::InheritedFlags::initialBackgroundColor):
• rendering/style/StyleBackgroundData.cpp: (WebCore::StyleBackgroundData::StyleBackgroundData):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/style/RenderStyle.h (modified) (1 diff)
• rendering/style/StyleBackgroundData.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
+
+        Reviewed by Eric Seidel.
+
+        [Qt] Make the default style background color valid.
+        Currently the color is transparent but invalid, this causes
+        list boxes in QtWebKit to be drawn with a black background
+        since r49242.
+        https://bugs.webkit.org/show_bug.cgi?id=31295
+
+        * rendering/style/RenderStyle.h:
+        (WebCore::InheritedFlags::initialBackgroundColor):
+        * rendering/style/StyleBackgroundData.cpp:
+        (WebCore::StyleBackgroundData::StyleBackgroundData):
+
 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
 

trunk/WebCore/rendering/style/RenderStyle.h

@@ -1182 +1182 @@
     static Length initialPerspectiveOriginX() { return Length(50.0, Percent); }
     static Length initialPerspectiveOriginY() { return Length(50.0, Percent); }
+    static Color initialBackgroundColor() { return Color::transparent; }
 
     // Keep these at the end.

trunk/WebCore/rendering/style/StyleBackgroundData.cpp

@@ -23 +23 @@
 #include "StyleBackgroundData.h"
 
+#include "RenderStyle.h"
 #include "RenderStyleConstants.h"
 
@@ -29 +30 @@
 StyleBackgroundData::StyleBackgroundData()
     : m_background(BackgroundFillLayer)
+    , m_color(RenderStyle::initialBackgroundColor())
 {
 }