Changeset 50888 in webkit

Timestamp:

Nov 12, 2009 11:21:52 AM (15 years ago)

Author:

dbates@webkit.org

Message:

2009-11-12 Daniel Bates <​dbates@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=30291

Fixes an issue where the returned drop effect is incorrect when
effectAllowed == "uninitialized".

According to section 7.9.2 of the HTML 5 spec.
<​http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
when effectAllowed = "uninitialized" the resulting dropEffect should be the
user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
other case.

No test cases are included because we have an existing test case from
bug #24731.

• dom/Clipboard.cpp: (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".

2009-11-12 Daniel Bates <​dbates@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=30291

Rebased results for existing test case fast/events/drag-and-drop.html
from bug #24731.

Now, we can run the part of the test when effectAllowed == "uninitialized".

• fast/events/drag-and-drop-expected.txt: Rebased results.
• fast/events/drag-and-drop.html: Removed notice about this bug (#30291).

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/drag-and-drop-expected.txt (modified) (2 diffs)
• LayoutTests/fast/events/drag-and-drop.html (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/Clipboard.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-11-12  Daniel Bates  <dbates@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        https://bugs.webkit.org/show_bug.cgi?id=30291
+
+        Rebased results for existing test case fast/events/drag-and-drop.html
+        from bug #24731.
+
+        Now, we can run the part of the test when effectAllowed == "uninitialized". 
+
+        * fast/events/drag-and-drop-expected.txt: Rebased results.
+        * fast/events/drag-and-drop.html: Removed notice about this bug (#30291).
+
 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
 

trunk/LayoutTests/fast/events/drag-and-drop-expected.txt

@@ -1 +1 @@
 This test checks that drag-and-drop support works and conforms to the HTML 5 specification.
 For each effectAllowed, iterates through the possible dropEffects: none, copy, move, link, dummy.
-
-Note, this test fails when effectAllowed == "uninitialized" because this effect has not been implemented yet (see bug #30291).
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
@@ -11 +9 @@
 
 PASS event.dataTransfer.dropEffect is "none"
-FAIL event.dataTransfer.dropEffect should be copy. Was none.
-FAIL event.dataTransfer.dropEffect should be move. Was none.
-FAIL event.dataTransfer.dropEffect should be link. Was none.
+PASS event.dataTransfer.dropEffect is "copy"
+PASS event.dataTransfer.dropEffect is "move"
+PASS event.dataTransfer.dropEffect is "link"
 PASS event.dataTransfer.dropEffect is "none"
 

trunk/LayoutTests/fast/events/drag-and-drop.html

@@ -177 +177 @@
     <script>
         description("This test checks that drag-and-drop support works and conforms to the HTML 5 specification.<br/>" +
-                    "For each effectAllowed, iterates through the possible dropEffects: none, copy, move, link, dummy.<br/><br/>" +
-                    "Note, this test fails when effectAllowed == &quot;uninitialized&quot; because this effect has not been " +
-                    "implemented yet (see bug #30291).");
+                    "For each effectAllowed, iterates through the possible dropEffects: none, copy, move, link, dummy.");
         var successfullyParsed = true;
     </script>

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-12  Daniel Bates  <dbates@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        https://bugs.webkit.org/show_bug.cgi?id=30291
+
+        Fixes an issue where the returned drop effect is incorrect when
+        effectAllowed == "uninitialized".
+
+        According to section 7.9.2 of the HTML 5 spec.
+        <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
+        when effectAllowed = "uninitialized" the resulting dropEffect should be the
+        user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
+        other case.
+        
+        No test cases are included because we have an existing test case from
+        bug #24731.
+
+        * dom/Clipboard.cpp:
+        (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
+
 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/WebCore/dom/Clipboard.cpp

@@ -56 +56 @@
 {
     // yep, it's really just this fixed set
+    if (op == "uninitialized")
+        return DragOperationEvery;
     if (op == "none")
         return DragOperationNone;