Changeset 51001 in webkit

Timestamp:

Nov 15, 2009 3:24:34 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2009-11-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Add bugzilla-tool check-style
​https://bugs.webkit.org/show_bug.cgi?id=31515

• Scripts/bugzilla-tool:
• Scripts/modules/bugzilla.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/bugzilla-tool (modified) (2 diffs)
• Scripts/modules/bugzilla.py (modified) (2 diffs)
• Scripts/modules/scm.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-11-15  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Add bugzilla-tool check-style
+        https://bugs.webkit.org/show_bug.cgi?id=31515
+
+        * Scripts/bugzilla-tool:
+        * Scripts/modules/bugzilla.py:
+
 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 

trunk/WebKitTools/Scripts/bugzilla-tool

@@ -136 +136 @@
 
 
+class CheckStyleOnBug(Command):
+    def __init__(self):
+        options = WebKitLandingScripts.cleaning_options()
+        Command.__init__(self, 'Runs check-webkit-style on the r? patches on a bug', 'BUGID', options=options)
+
+    @classmethod
+    def check_style(cls, bug_id, patch, options, tool):
+        tool.scm().update_webkit()
+        log("Checking style for patch %s from bug %s." % (patch['id'], bug_id))
+        try:
+            tool.scm().apply_patch(patch)
+            WebKitLandingScripts.run_webkit_script("check-webkit-style")
+        except ScriptError, e:
+            log("Patch failed to apply and check style")
+            log(e.output)
+
+        tool.scm().ensure_clean_working_directory(True)
+
+    def execute(self, options, args, tool):
+        bug_id = args[0]
+        patches = tool.bugs.fetch_unreviewed_patches_from_bug(bug_id)
+
+        WebKitLandingScripts.setup_for_landing(tool.scm(), options)
+
+        for patch in patches:
+            self.check_style(bug_id, patch, options, tool)
+
+
 class ApplyPatchesFromBug(Command):
     def __init__(self):
@@ -813 +841 @@
             { 'name' : 'land-diff', 'object' : LandAndUpdateBug() },
             { 'name' : 'land-patches', 'object' : LandPatchesFromBugs() },
+            { 'name' : 'check-style', 'object' : CheckStyleOnBug() },
             { 'name' : 'commit-message', 'object' : CommitMessageForCurrentDiff() },
             { 'name' : 'obsolete-attachments', 'object' : ObsoleteAttachmentsOnBug() },

trunk/WebKitTools/Scripts/modules/bugzilla.py

@@ -164 +164 @@
     def _parse_attachment_flag(self, element, flag_name, attachment, result_key):
         flag = element.find('flag', attrs={'name' : flag_name})
-        if flag and flag['status'] == '+':
-            attachment[result_key] = flag['setter']
+        if flag:
+            attachment[flag_name] = flag['status']
+            if flag['status'] == '+':
+                attachment[result_key] = flag['setter']
 
     def _parse_attachment_element(self, element, bug_id):
@@ -233 +235 @@
     def _validate_committer(self, patch, reject_invalid_patches):
         return self._validate_setter_email(patch, 'committer', self.committers.committer_by_email, self.reject_patch_from_commit_queue, reject_invalid_patches)
+
+    def fetch_unreviewed_patches_from_bug(self, bug_id):
+        unreviewed_patches = []
+        for attachment in self.fetch_attachments_from_bug(bug_id):
+            if attachment.get('review') == '?' and not attachment['is_obsolete']:
+                unreviewed_patches.append(attachment)
+        return unreviewed_patches
 
     def fetch_reviewed_patches_from_bug(self, bug_id, reject_invalid_patches=False):

trunk/WebKitTools/Scripts/modules/scm.py

@@ -169 +169 @@
         # We should detect and handle that case.
         curl_process = subprocess.Popen(['curl', '--location', '--silent', '--show-error', patch['url']], stdout=subprocess.PIPE)
-        args = [self.script_path('svn-apply'), '--reviewer', patch['reviewer']]
+        args = [self.script_path('svn-apply')]
+        if patch.get('reviewer'):
+            args += ['--reviewer', patch['reviewer']]
         if force:
             args.append('--force')