Changeset 51205 in webkit

Timestamp:

Nov 19, 2009 2:04:51 PM (14 years ago)

Author:

oliver@apple.com

Message:

-webkit-user-drag: element Drag images include overflow decorations from incorrect nodes
​https://bugs.webkit.org/show_bug.cgi?id=31656

Reviewed Dave Hyatt

Make sure we're a child of the painting root before drawing overflow features.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• manual-tests/user-drag-with-decorations.html (added)
• rendering/RenderBlock.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-19  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Dave Hyatt.
+
+        -webkit-user-drag: element Drag images include overflow decorations from incorrect nodes
+        https://bugs.webkit.org/show_bug.cgi?id=31656
+
+        Make sure we're a child of the painting root before drawing overflow features.
+
+        * manual-tests/user-drag-with-decorations.html: Added.
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::paint):
+
 2009-11-19  Dmitry Titov  <dimich@chromium.org>
 

trunk/WebCore/rendering/RenderBlock.cpp

@@ -1524 +1524 @@
     // z-index.  We paint after we painted the background/border, so that the scrollbars will
     // sit above the background/border.
-    if (hasOverflowClip() && style()->visibility() == VISIBLE && (phase == PaintPhaseBlockBackground || phase == PaintPhaseChildBlockBackground))
+    if (hasOverflowClip() && style()->visibility() == VISIBLE && (phase == PaintPhaseBlockBackground || phase == PaintPhaseChildBlockBackground) && shouldPaintWithinRoot(paintInfo))
         layer()->paintOverflowControls(paintInfo.context, tx, ty, paintInfo.rect);
 }