Changeset 51244 in webkit

Timestamp:

Nov 20, 2009 11:06:02 AM (14 years ago)

Author:

eric@webkit.org

Message:

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make commit-queue and style-queue show up in help
​https://bugs.webkit.org/show_bug.cgi?id=31724

We need to store their names on their class to make these commands
properly register themselves with MultiCommandTool.

• Scripts/bugzilla-tool:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/bugzilla-tool (modified) (5 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-11-20  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Make commit-queue and style-queue show up in help
+        https://bugs.webkit.org/show_bug.cgi?id=31724
+
+        We need to store their names on their class to make these commands
+        properly register themselves with MultiCommandTool.
+
+        * Scripts/bugzilla-tool:
+
 2009-11-20  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/bugzilla-tool

@@ -633 +633 @@
 
 class AbstractQueue(Command, WorkQueueDelegate):
-    def __init__(self, name):
-        self._name = name
+    def __init__(self):
         options = [
             make_option("--no-confirm", action="store_false", dest="confirm", default=True, help="Do not ask the user for confirmation before running the queue.  Dangerous!"),
             make_option("--status-host", action="store", type="string", dest="status_host", default=StatusBot.default_host, help="Hostname (e.g. localhost or commit.webkit.org) where status updates should be posted."),
         ]
-        Command.__init__(self, "Run the %s." % self._name, options=options)
+        Command.__init__(self, "Run the %s." % self.name, options=options)
 
     def queue_log_path(self):
-        return "%s.log" % self._name
+        return "%s.log" % self.name
 
     def work_logs_directory(self):
-        return "%s-logs" % self._name
+        return "%s-logs" % self.name
 
     def status_host(self):
@@ -651 +650 @@
 
     def begin_work_queue(self):
-        log("CAUTION: %s will discard all local changes in %s" % (self._name, self.tool.scm().checkout_root))
+        log("CAUTION: %s will discard all local changes in %s" % (self.name, self.tool.scm().checkout_root))
         if self.options.confirm:
             response = raw_input("Are you sure?  Type \"yes\" to continue: ")
             if (response != "yes"):
                 error("User declined.")
-        log("Running WebKit %s. %s" % (self._name, datetime.now().strftime(WorkQueue.log_date_format)))
+        log("Running WebKit %s. %s" % (self.name, datetime.now().strftime(WorkQueue.log_date_format)))
 
     def should_continue_work_queue(self):
@@ -680 +679 @@
 
     def log_progress(self, patch_ids):
-        log("%s in %s [%s]" % (pluralize("patch", len(patch_ids)), self._name, ", ".join(patch_ids)))
+        log("%s in %s [%s]" % (pluralize("patch", len(patch_ids)), self.name, ", ".join(patch_ids)))
 
     def execute(self, options, args, tool):
@@ -690 +689 @@
 
 class CommitQueue(AbstractQueue):
-    def __init__(self):
-        AbstractQueue.__init__(self, "commit-queue")
+    name = "commit-queue"
+    def __init__(self):
+        AbstractQueue.__init__(self)
 
     def begin_work_queue(self):
@@ -719 +719 @@
 
 class StyleQueue(AbstractQueue):
-    def __init__(self):
-        AbstractQueue.__init__(self, "style-queue")
+    name = "style-queue"
+    def __init__(self):
+        AbstractQueue.__init__(self)
 
     def status_host(self):