Changeset 51248 in webkit

Timestamp:

Nov 20, 2009 11:22:46 AM (14 years ago)

Author:

eric@webkit.org

Message:

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement a build-queue
​https://bugs.webkit.org/show_bug.cgi?id=31725

Currently this just builds the first 10 patches in the review queue.
We'll want to do something smarter soon.

• Scripts/bugzilla-tool:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/bugzilla-tool (modified) (3 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-11-20  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Implement a build-queue
+        https://bugs.webkit.org/show_bug.cgi?id=31725
+
+        Currently this just builds the first 10 patches in the review queue.
+        We'll want to do something smarter soon.
+
+        * Scripts/bugzilla-tool:
+
 2009-11-20  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/bugzilla-tool

@@ -718 +718 @@
 
 
-class StyleQueue(AbstractQueue):
-    name = "style-queue"
+class AbstractTryQueue(AbstractQueue):
     def __init__(self):
         AbstractQueue.__init__(self)
@@ -736 +735 @@
 
     def should_proceed_with_work_item(self, patch):
+        raise NotImplementedError, "subclasses must implement"
+
+    def process_work_item(self, patch):
+        raise NotImplementedError, "subclasses must implement"
+
+    def handle_unexpected_error(self, patch, message):
+        log(message)
+
+
+class StyleQueue(AbstractTryQueue):
+    name = "style-queue"
+    def __init__(self):
+        AbstractTryQueue.__init__(self)
+
+    def should_proceed_with_work_item(self, patch):
         return (True, "Checking style for patch %s on bug %s." % (patch["id"], patch["bug_id"]), patch["bug_id"])
 
@@ -741 +755 @@
         self.run_bugzilla_tool(["check-style", "--force-clean", patch["id"]])
 
-    def handle_unexpected_error(self, patch, message):
-        log(message)
+
+class BuildQueue(AbstractTryQueue):
+    name = "build-queue"
+    def __init__(self):
+        AbstractTryQueue.__init__(self)
+
+    def should_proceed_with_work_item(self, patch):
+        # FIXME: We should check whether we're currently able to build!
+        return (True, "Building patch %s on bug %s." % (patch["id"], patch["bug_id"]), patch["bug_id"])
+
+    def process_work_item(self, patch):
+        self.run_bugzilla_tool(["build-attachment", "--force-clean", patch["id"]])