Changeset 51280 in webkit

Timestamp:

Nov 20, 2009 8:50:21 PM (14 years ago)

Author:

jhoneycutt@apple.com

Message:

DOMElement::tagName() is unimplemented

​https://bugs.webkit.org/show_bug.cgi?id=31746

Reviewed by Darin Adler.

• DOMCoreClasses.cpp:

(DOMElement::tagName):
Create a BString from the element's tag name, and release its BSTR
into result.

Location:

trunk/WebKit/win

Files:

• ChangeLog (modified) (1 diff)
• DOMCoreClasses.cpp (modified) (1 diff)

trunk/WebKit/win/ChangeLog

@@ +1 @@
+2009-11-20  Jon Honeycutt  <jhoneycutt@apple.com>
+
+        DOMElement::tagName() is unimplemented
+
+        https://bugs.webkit.org/show_bug.cgi?id=31746
+
+        Reviewed by Darin Adler.
+
+        * DOMCoreClasses.cpp:
+        (DOMElement::tagName):
+        Create a BString from the element's tag name, and release its BSTR
+        into result.
+
 2009-11-20  Jon Honeycutt  <jhoneycutt@apple.com>
 

trunk/WebKit/win/DOMCoreClasses.cpp

@@ -835 +835 @@
 
 HRESULT STDMETHODCALLTYPE DOMElement::tagName( 
-        /* [retval][out] */ BSTR* /*result*/)
-{
-    ASSERT_NOT_REACHED();
-    return E_NOTIMPL;
+        /* [retval][out] */ BSTR* result)
+{
+    if (!m_element)
+        return E_FAIL;
+
+    if (!result)
+        return E_POINTER;
+
+    *result = BString(m_element->tagName()).release();
+    return S_OK;
 }