Changeset 51380 in webkit

Timestamp:

Nov 25, 2009 5:01:00 AM (14 years ago)

Author:

kov@webkit.org

Message:

Reviewed by Xan Lopez.

Some tests are crashing from time to time
​https://bugs.webkit.org/show_bug.cgi?id=31866

Make sure we do not notify the client of a finished load, if the
load has been cancelled, or the client is gone.

• platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/soup/ResourceHandleSoup.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
+
+        Reviewed by Xan Lopez.
+
+        Some tests are crashing from time to time
+        https://bugs.webkit.org/show_bug.cgi?id=31866
+
+        Make sure we do not notify the client of a finished load, if the
+        load has been cancelled, or the client is gone.
+
+        * platform/network/soup/ResourceHandleSoup.cpp:
+        (WebCore::):
+
 2009-11-24  Ben Murdoch  <benm@google.com>
 

trunk/WebCore/platform/network/soup/ResourceHandleSoup.cpp

@@ -694 +694 @@
     g_input_stream_close_finish(d->m_inputStream, res, 0);
     cleanupGioOperation(handle.get());
+
+    // The load may have been cancelled, the client may have been
+    // destroyed already. In such cases calling didFinishLoading is a
+    // bad idea.
+    if (d->m_cancelled || !client)
+        return;
+
     client->didFinishLoading(handle.get());
 }