Changeset 51443 in webkit

Timestamp:

Nov 27, 2009 10:09:36 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2009-11-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] unit test ApplyPatches and ApplyAttachment
​https://bugs.webkit.org/show_bug.cgi?id=31935

• Scripts/modules/commands/download.py:
• Scripts/modules/commands/download_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/modules/commands/download.py (modified) (2 diffs)
• Scripts/modules/commands/download_unittest.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-11-27  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        [bzt] unit test ApplyPatches and ApplyAttachment
+        https://bugs.webkit.org/show_bug.cgi?id=31935
+
+        * Scripts/modules/commands/download.py:
+        * Scripts/modules/commands/download_unittest.py:
+
 2009-11-27  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/modules/commands/download.py

@@ -80 +80 @@
 
 
-# FIXME: Requires unit test. Blocking issue: WebKitApplyingScripts
 class ApplyAttachment(Command):
     name = "apply-attachment"
@@ -96 +95 @@
 
 
-# FIXME: Requires unit test. Blocking issue: WebKitApplyingScripts
 class ApplyPatches(Command):
     name = "apply-patches"

trunk/WebKitTools/Scripts/modules/commands/download_unittest.py

@@ -50 +50 @@
         self.assert_execute_outputs(Build(), [], options=self._default_options())
 
+    def test_apply_attachment(self):
+        options = self._default_options()
+        options.update = True
+        options.local_commit = True
+        self.assert_execute_outputs(ApplyAttachment(), [197], options=options)
+
+    def test_apply_patches(self):
+        options = self._default_options()
+        options.update = True
+        options.local_commit = True
+        self.assert_execute_outputs(ApplyPatches(), [42], options=options)
+
     def test_land_diff(self):
         self.assert_execute_outputs(LandDiff(), [42], options=self._default_options())