Changeset 51444 in webkit

Timestamp:

Nov 27, 2009 10:49:01 AM (14 years ago)

Author:

eric@webkit.org

Message:

2009-11-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make commit-queue status not throw an exception where there is not
status
​https://bugs.webkit.org/show_bug.cgi?id=31936

We need to actually fetch the results of the query to see what's in the
datastore.

• CommitQueueStatus/queue_status.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• CommitQueueStatus/queue_status.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-11-27  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Make commit-queue status not throw an exception where there is not
+        status
+        https://bugs.webkit.org/show_bug.cgi?id=31936
+
+        We need to actually fetch the results of the query to see what's in the
+        datastore.
+
+        * CommitQueueStatus/queue_status.py:
+
 2009-11-27  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/CommitQueueStatus/queue_status.py

@@ -67 +67 @@
 class PatchStatus(webapp.RequestHandler):
     def get(self, queue_name, attachment_id):
-        statuses = QueueStatus.all().filter('queue_name =', queue_name).filter('active_patch_id =', attachment_id).order('-date')
+        statuses = QueueStatus.all().filter('queue_name =', queue_name).filter('active_patch_id =', attachment_id).order('-date').fetch(1)
         if not statuses:
             self.error(404)
+            return
         self.response.out.write(statuses[0].message)