Changeset 51456 in webkit


Ignore:
Timestamp:
Nov 27, 2009 11:39:12 PM (14 years ago)
Author:
yurys@chromium.org
Message:

2009-11-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Add separate method for pause command to WebDevToolsAgent
and WebDevToolsFrontendClient interfaces so that pause command
can be processed on the IO thread.

https://bugs.webkit.org/show_bug.cgi?id=31934

  • public/WebDevToolsAgent.h:
  • public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendDebuggerCommandToAgent): (WebKit::WebDevToolsFrontendClient::sendDebuggerPauseScript): (WebKit::WebDevToolsFrontendClient::activateWindow): (WebKit::WebDevToolsFrontendClient::closeWindow): (WebKit::WebDevToolsFrontendClient::dockWindow): (WebKit::WebDevToolsFrontendClient::undockWindow):
Location:
trunk/WebKit/chromium
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/chromium/ChangeLog

    r51440 r51456  
     12009-11-27  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Add separate method for pause command to WebDevToolsAgent
     6        and WebDevToolsFrontendClient interfaces so that pause command
     7        can be processed on the IO thread.
     8
     9        https://bugs.webkit.org/show_bug.cgi?id=31934
     10
     11        * public/WebDevToolsAgent.h:
     12        * public/WebDevToolsFrontendClient.h:
     13        (WebKit::WebDevToolsFrontendClient::sendDebuggerCommandToAgent):
     14        (WebKit::WebDevToolsFrontendClient::sendDebuggerPauseScript):
     15        (WebKit::WebDevToolsFrontendClient::activateWindow):
     16        (WebKit::WebDevToolsFrontendClient::closeWindow):
     17        (WebKit::WebDevToolsFrontendClient::dockWindow):
     18        (WebKit::WebDevToolsFrontendClient::undockWindow):
     19
    1202009-11-27  Yury Semikhatsky  <yurys@chromium.org>
    221
  • trunk/WebKit/chromium/public/WebDevToolsAgent.h

    r51440 r51456  
    7070        const WebString& command, int callerIdentifier);
    7171
     72    // Asynchronously request debugger to pause immediately.
     73    WEBKIT_API static void debuggerPauseScript();
     74
    7275    typedef void (*MessageLoopDispatchHandler)();
    7376
  • trunk/WebKit/chromium/public/WebDevToolsFrontendClient.h

    r50683 r51456  
    4444                                    const WebString& param1,
    4545                                    const WebString& param2,
    46                                     const WebString& param3) = 0;
    47     virtual void sendDebuggerCommandToAgent(const WebString& command) = 0;
     46                                    const WebString& param3) {};
     47    virtual void sendDebuggerCommandToAgent(const WebString& command) {};
     48    virtual void sendDebuggerPauseScript() {}
    4849
    49     virtual void activateWindow() = 0;
    50     virtual void closeWindow() = 0;
    51     virtual void dockWindow() = 0;
    52     virtual void undockWindow() = 0;
     50    virtual void activateWindow() {};
     51    virtual void closeWindow() {};
     52    virtual void dockWindow() {};
     53    virtual void undockWindow() {};
    5354
    5455protected:
Note: See TracChangeset for help on using the changeset viewer.