Changeset 51462 in webkit

Timestamp:

Nov 28, 2009 4:17:33 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2009-11-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] style-queue should report style errors to bugzilla
​https://bugs.webkit.org/show_bug.cgi?id=31945

Currently, we're just logging the style errors locally. With this
patch we'll actually log the errors to bugzilla. Note: I plan to run
with the "local-only" logging during development.

• Scripts/modules/commands/queues.py:
• Scripts/modules/scm.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/modules/commands/queues.py (modified) (1 diff)
• Scripts/modules/scm.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-11-28  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        [bzt] style-queue should report style errors to bugzilla
+        https://bugs.webkit.org/show_bug.cgi?id=31945
+
+        Currently, we're just logging the style errors locally.  With this
+        patch we'll actually log the errors to bugzilla.  Note: I plan to run
+        with the "local-only" logging during development.
+
+        * Scripts/modules/commands/queues.py:
+        * Scripts/modules/scm.py:
+
 2009-11-28  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/modules/commands/queues.py

@@ -203 +203 @@
         self._patches.done(patch)
 
+    @classmethod
+    def handle_script_error(cls, tool, patch, script_error):
+        command = script_error.script_args
+        if type(command) is list:
+            command = command[0]
+        # FIXME: We shouldn't need to use a regexp here.  ScriptError should
+        #        have a better API.
+        if re.search("check-webkit-style", command):
+            message = "Attachment %s did not pass %s:\n\n%s" % (patch["id"], cls.name, script_error.message_with_output(output_limit=None))
+            # Local-only logging helpful for development:
+            # log("** BEGIN BUG POST **\n%s** END BUG POST **" % message)
+            tool.bugs.post_comment_to_bug(patch["bug_id"], message)
+
 
 class BuildQueue(AbstractTryQueue):

trunk/WebKitTools/Scripts/modules/scm.py

@@ -96 +96 @@
     def message_with_output(self, output_limit=500):
         if self.output:
-            if len(self.output) > output_limit:
+            if output_limit and len(self.output) > output_limit:
                  return "%s\nLast %s characters of output:\n%s" % (self, output_limit, self.output[-output_limit:])
             return "%s\n%s" % (self, self.output)