Changeset 51705 in webkit

Timestamp:

Dec 4, 2009 12:01:20 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-04 Zoltan Herczeg <​zherczeg@inf.u-szeged.hu>

Reviewed by Darin Adler.

Check whether the right side of a string append is non-empty
​https://bugs.webkit.org/show_bug.cgi?id=32151

Especially beneficial for CachedScript::script() method
which usually appends an empty string returned by flush()
to its m_script member. m_script is often hundreds of kbytes
which is duplated without reason.

• platform/text/String.cpp: (WebCore::String::append):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/text/String.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-04  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
+
+        Reviewed by Darin Adler.
+
+        Check whether the right side of a string append is non-empty
+        https://bugs.webkit.org/show_bug.cgi?id=32151
+
+        Especially beneficial for CachedScript::script() method
+        which usually appends an empty string returned by flush()
+        to its m_script member. m_script is often hundreds of kbytes
+        which is duplated without reason.
+
+        * platform/text/String.cpp:
+        (WebCore::String::append):
+
 2009-12-04  Enrica Casucci  <enrica@apple.com>
 

trunk/WebCore/platform/text/String.cpp

@@ -82 +82 @@
 void String::append(const String& str)
 {
+    if (str.isEmpty())
+       return;
+
     // FIXME: This is extremely inefficient. So much so that we might want to take this
     // out of String's API. We can make it better by optimizing the case where exactly