Changeset 51767 in webkit


Ignore:
Timestamp:
Dec 7, 2009 7:31:42 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-12-07 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Improve the autotests of QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=32216

Remove the calls to qWait() of the autotest of QWebView

  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::reusePage):
Location:
trunk/WebKit/qt
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/qt/ChangeLog

    r51763 r51767  
     12009-12-07  Benjamin Poulain  <benjamin.poulain@nokia.com>
     2
     3        Reviewed by Kenneth Rohde Christiansen.
     4
     5        [Qt] Improve the autotests of QtWebkit
     6        https://bugs.webkit.org/show_bug.cgi?id=32216
     7
     8        Remove the calls to qWait() of the autotest of QWebView
     9
     10        * tests/qwebview/tst_qwebview.cpp:
     11        (tst_QWebView::reusePage):
     12
    1132009-12-07  Benjamin Poulain  <benjamin.poulain@nokia.com>
    214
  • trunk/WebKit/qt/tests/qwebview/tst_qwebview.cpp

    r50415 r51767  
    133133    if (html.contains("</embed>")) {
    134134        // some reasonable time for the PluginStream to feed test.swf to flash and start painting
    135         QTest::qWait(2000);
     135        waitForSignal(view1, SIGNAL(loadFinished(bool)), 2000);
    136136    }
    137137
    138138    view1->show();
    139     QTest::qWait(2000);
     139    QTest::qWaitForWindowShown(view1);
    140140    delete view1;
    141141    QVERIFY(page != 0); // deleting view must not have deleted the page, since it's not a child of view
     
    144144    view2->setPage(page);
    145145    view2->show(); // in Windowless mode, you should still be able to see the plugin here
    146     QTest::qWait(2000);
     146    QTest::qWaitForWindowShown(view2);
    147147    delete view2;
    148148
Note: See TracChangeset for help on using the changeset viewer.