Changeset 51789 in webkit

Timestamp:

Dec 7, 2009 12:32:07 PM (14 years ago)

Author:

krit@webkit.org

Message:

2009-12-07 Shiki Okasaka <​shiki@google.com>

Reviewed by Dirk Schulze.

Avoid zero division during SVGPaintServerPattern::setup()
​https://bugs.webkit.org/show_bug.cgi?id=29912

Fix zero division bugs in SVGPaintServerPattern::setup() that occurred
if the tile of a pattern was bigger than the pattern and the pattern
size was < 0.5, and if the attribute overflow was set to visible.

Test: svg/custom/small-pattern.html

• svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):

2009-12-07 Dirk Schulze <​krit@webkit.org>

Reviewed by Adam Barth.

If the tile of a pattern is bigger than the pattern and the
pattern size is < 0.5, the SVGPaintServer produced a division
by zero. This also only happens, if the attribute overflow is
set to visible.
This is a test with a pattern size of 0.1 and a tile size of 1.

• svg/custom/script-tests/small-pattern.js: Added.
• svg/custom/small-pattern-expected.txt: Added.
• svg/custom/small-pattern.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/custom/script-tests/small-pattern.js (added)
• LayoutTests/svg/custom/small-pattern-expected.txt (added)
• LayoutTests/svg/custom/small-pattern.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/svg/graphics/SVGPaintServerPattern.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-12-07  Dirk Schulze  <krit@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        If the tile of a pattern is bigger than the pattern and the
+        pattern size is < 0.5, the SVGPaintServer produced a division
+        by zero. This also only happens, if the attribute overflow is
+        set to visible.
+        This is a test with a pattern size of 0.1 and a tile size of 1. 
+
+        * svg/custom/script-tests/small-pattern.js: Added.
+        * svg/custom/small-pattern-expected.txt: Added.
+        * svg/custom/small-pattern.html: Added.
+
 2009-12-07  Kenneth Russell  <kbr@google.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-07  Shiki Okasaka  <shiki@google.com>
+
+        Reviewed by Dirk Schulze.
+
+        Avoid zero division during SVGPaintServerPattern::setup()
+        https://bugs.webkit.org/show_bug.cgi?id=29912
+
+        Fix zero division bugs in SVGPaintServerPattern::setup() that occurred
+        if the tile of a pattern was bigger than the pattern and the pattern
+        size was < 0.5, and if the attribute overflow was set to visible.
+
+        Test: svg/custom/small-pattern.html
+
+        * svg/graphics/SVGPaintServerPattern.cpp:
+        (WebCore::SVGPaintServerPattern::setup):
+
 2009-12-07  Kenneth Russell  <kbr@google.com>
 

trunk/WebCore/svg/graphics/SVGPaintServerPattern.cpp

@@ -123 +123 @@
         GraphicsContext* tileImageContext = tileImage->context();
 
-        int numY = static_cast<int>(ceilf(tileRect.height() / tileHeight)) + 1;
-        int numX = static_cast<int>(ceilf(tileRect.width() / tileWidth)) + 1;
+        int numY = static_cast<int>(ceilf(tileRect.height() / patternBoundaries().height())) + 1;
+        int numX = static_cast<int>(ceilf(tileRect.width() / patternBoundaries().width())) + 1;
 
         tileImageContext->save();