Changeset 51895 in webkit


Ignore:
Timestamp:
Dec 9, 2009 1:39:10 AM (14 years ago)
Author:
abarth@webkit.org
Message:

2009-12-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Remove unused PatchCollection class
​https://bugs.webkit.org/show_bug.cgi?id=32312

It's dead code.

  • Scripts/modules/patchcollection.py:
  • Scripts/modules/patchcollection_unittest.py: Removed.
Location:
trunk/WebKitTools
Files:
1 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKitTools/ChangeLog

    r51894 r51895  
     12009-12-09  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [bzt] Remove unused PatchCollection class
     6        https://bugs.webkit.org/show_bug.cgi?id=32312
     7
     8        It's dead code.
     9
     10        * Scripts/modules/patchcollection.py:
     11        * Scripts/modules/patchcollection_unittest.py: Removed.
     12
    1132009-12-09  Adam Barth  <abarth@webkit.org>
    214

  • trunk/WebKitTools/Scripts/modules/commands/queues.py

    r51889 r51895  
    3939from modules.logging import error, log
    4040from modules.multicommandtool import Command
    41 from modules.patchcollection import PatchCollection, PersistentPatchCollection, PersistentPatchCollectionDelegate
     41from modules.patchcollection import PersistentPatchCollection, PersistentPatchCollectionDelegate
    4242from modules.statusbot import StatusBot
    4343from modules.workqueue import WorkQueue, WorkQueueDelegate

  • trunk/WebKitTools/Scripts/modules/patchcollection.py

    r51518 r51895  
    2727# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
    2828# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    29 
    30 class PatchCollection:
    31     def __init__(self, bugs, filter=None):
    32         self._bugs = bugs
    33         self._filter = filter
    34         self._patches = []
    35 
    36     def add(self, patch):
    37         self.add_patches([patch])
    38 
    39     def add_patches(self, patches):
    40         for patch in patches:
    41             if not patch:
    42                 continue
    43             if self._filter and not self._filter(patch):
    44                 continue
    45             self._patches.append(patch)
    46 
    47     def add_patches_from_bug(self, bug_id):
    48         self.add_patches(self._bugs.fetch_patches_from_bug(bug_id))
    49 
    50     def next(self):
    51         if not self._patches:
    52             return None
    53         return self._patches.pop(0)
    54 
    55     def patch_ids(self):
    56         return map(lambda patch: patch['id'], self._patches)
    57 
    58     def __len__(self):
    59         return len(self._patches)
    60 
    6129
    6230class PersistentPatchCollectionDelegate:

  • trunk/WebKitTools/Scripts/run-webkit-unittests

    r51622 r51895  
    4242from modules.logging_unittest import *
    4343from modules.multicommandtool_unittest import *
    44 from modules.patchcollection_unittest import *
    4544from modules.scm_unittest import *
    4645from modules.webkitport_unittest import *
Note: See TracChangeset for help on using the changeset viewer.