Changeset 51927 in webkit

Timestamp:

Dec 9, 2009 2:54:17 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-09 Steve Block <​steveblock@google.com>

Reviewed by Darin Adler.

Adds ENABLE(INSPECTOR) guards around script binding methods that use types
defined only when INSPECTOR is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=32328

Build fix only, no new tests.

• bindings/js/ScriptValue.cpp: Modified. Added ENABLE(INSPECTOR) guard to ScriptValue::quarantineValue.
• bindings/v8/ScriptObject.cpp: Modified. Added ENABLE(INSPECTOR) guard to some overloads of ScriptGlobalObject::set.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/ScriptValue.cpp (modified) (2 diffs)
• bindings/v8/ScriptObject.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-09  Steve Block  <steveblock@google.com>
+
+        Reviewed by Darin Adler.
+
+        Adds ENABLE(INSPECTOR) guards around script binding methods that use types
+        defined only when INSPECTOR is enabled.
+        https://bugs.webkit.org/show_bug.cgi?id=32328
+
+        Build fix only, no new tests.
+
+        * bindings/js/ScriptValue.cpp: Modified. Added ENABLE(INSPECTOR) guard to ScriptValue::quarantineValue.
+        * bindings/v8/ScriptObject.cpp: Modified. Added ENABLE(INSPECTOR) guard to some overloads of ScriptGlobalObject::set.
+
 2009-12-09  Steve Block  <steveblock@google.com>
 

trunk/WebCore/bindings/js/ScriptValue.cpp

@@ -43 +43 @@
 namespace WebCore {
 
+#if ENABLE(INSPECTOR)
 ScriptValue ScriptValue::quarantineValue(ScriptState* scriptState, const ScriptValue& value)
 {
@@ -48 +49 @@
     return ScriptValue(JSInspectedObjectWrapper::wrap(scriptState, value.jsValue()));
 }
+#endif
 
 bool ScriptValue::getString(ScriptState* scriptState, String& result) const

trunk/WebCore/bindings/v8/ScriptObject.cpp

@@ -141 +141 @@
 }
 
+#if ENABLE(INSPECTOR)
 bool ScriptGlobalObject::set(ScriptState* scriptState, const char* name, InspectorBackend* value)
 {
@@ -161 +162 @@
     return scope.success();
 }
+#endif
 
 bool ScriptGlobalObject::get(ScriptState* scriptState, const char* name, ScriptObject& value)