Changeset 51995 in webkit

Timestamp:

Dec 11, 2009 9:14:06 AM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-11 anton muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] in Debug builds create an additional handle scope
when doing debug build checks.
​https://bugs.webkit.org/show_bug.cgi?id=32335

Should be covered by buildbots.

• bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::convertDOMWrapperToNode):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8DOMWrapper.h (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-11  anton muhin  <antonm@chromium.org>
+        Reviewed by Adam Barth.
+
+        [v8] in Debug builds create an additional handle scope
+        when doing debug build checks.
+        https://bugs.webkit.org/show_bug.cgi?id=32335
+
+        Should be covered by buildbots.
+
+        * bindings/v8/V8DOMWrapper.h:
+        (WebCore::V8DOMWrapper::convertDOMWrapperToNative):
+        (WebCore::V8DOMWrapper::convertDOMWrapperToNode):
+
 2009-12-11  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/WebCore/bindings/v8/V8DOMWrapper.h

@@ -127 +127 @@
         static C* convertDOMWrapperToNative(v8::Handle<v8::Object> object)
         {
+#ifndef NDEBUG
+            v8::HandleScope handleScope;
             ASSERT(maybeDOMWrapper(object));
+#endif
             return reinterpret_cast<C*>(object->GetPointerFromInternalField(V8Custom::kDOMWrapperObjectIndex));
         }
@@ -134 +137 @@
         static C* convertDOMWrapperToNode(v8::Handle<v8::Object> object)
         {
+#ifndef NDEBUG
+            v8::HandleScope handleScope;
             ASSERT(maybeDOMWrapper(object));
             ASSERT(domWrapperType(object) == V8ClassIndex::NODE);
+#endif
             return convertDOMWrapperToNative<C>(object);
         }