Changeset 52049 in webkit

Timestamp:

Dec 12, 2009 2:20:57 AM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-12 Dirk Schulze <​krit@webkit.org>

Reviewed by Eric Seidel.

[Cairo][Qt] Alpha blending in SVG filters is wrong
​https://bugs.webkit.org/show_bug.cgi?id=32427

This patch is a follow-up to:
​http://trac.webkit.org/changeset/51950
It fixes the alpha blending for Cairo and Qt on SVG Filters.

Covered by: * LayoutTests/svg/filters/feGaussianBlur.svg

• LayoutTests/svg/filters/feComposite.svg and others.

• platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):
• platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/cairo/ImageBufferCairo.cpp (modified) (1 diff)
• platform/graphics/qt/ImageBufferQt.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-12  Dirk Schulze  <krit@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        [Cairo][Qt] Alpha blending in SVG filters is wrong
+        https://bugs.webkit.org/show_bug.cgi?id=32427
+
+        This patch is a follow-up to:
+        http://trac.webkit.org/changeset/51950
+        It fixes the alpha blending for Cairo and Qt on SVG Filters.
+
+        Covered by: * LayoutTests/svg/filters/feGaussianBlur.svg
+                    * LayoutTests/svg/filters/feComposite.svg
+                     and others.
+
+        * platform/graphics/cairo/ImageBufferCairo.cpp:
+        (WebCore::ImageBuffer::platformTransformColorSpace):
+        * platform/graphics/qt/ImageBufferQt.cpp:
+        (WebCore::ImageBuffer::platformTransformColorSpace):
+
 2009-12-11  Eric Roman  <eroman@chromium.org>
 

trunk/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp

@@ -133 +133 @@
                                lookUpTable[pixelColor.green()],
                                lookUpTable[pixelColor.blue()],
-                               lookUpTable[pixelColor.alpha()]);
+                               pixelColor.alpha());
             *pixel = premultipliedARGBFromColor(pixelColor);
         }

trunk/WebCore/platform/graphics/qt/ImageBufferQt.cpp

@@ -115 +115 @@
                           lookUpTable[qGreen(value)],
                           lookUpTable[qBlue(value)],
-                          lookUpTable[qAlpha(value)]);
+                          qAlpha(value));
             image.setPixel(x, y, value);
         }