Changeset 52089 in webkit
- Timestamp:
- Dec 14, 2009 3:09:13 AM (14 years ago)
- Location:
- trunk/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r52086 r52089 1 2009-12-03 Holger Hans Peter Freyther <zecke@selfish.org> 2 3 Reviewed by Simon Hausmann. 4 5 [Qt] Connect QNetworkReply via direct connections. 6 https://bugs.webkit.org/show_bug.cgi?id=32113 7 8 In the past we have switched from auto connections to queued 9 connections to get some more stability. The problem with the 10 Queued connections is latency. Even when running simple loading 11 tests the time it takes to runs highly varies and by using 12 direct connections these tests produce a stable result. 13 14 We will have to look out for crashes coming from within the 15 QNetworkAccessManager due this patch and address them then. 16 17 * platform/network/qt/QNetworkReplyHandler.cpp: 18 (WebCore::QNetworkReplyHandler::start): 19 1 20 2009-12-14 Holger Hans Peter Freyther <zecke@selfish.org> 2 21 -
trunk/WebCore/platform/network/qt/QNetworkReplyHandler.cpp
r51411 r52089 428 428 429 429 connect(m_reply, SIGNAL(finished()), 430 this, SLOT(finish()), Qt:: QueuedConnection);430 this, SLOT(finish()), Qt::DirectConnection); 431 431 432 432 // For http(s) we know that the headers are complete upon metaDataChanged() emission, so we … … 434 434 if (scheme == QLatin1String("http") || scheme == QLatin1String("https")) 435 435 connect(m_reply, SIGNAL(metaDataChanged()), 436 this, SLOT(sendResponseIfNeeded()), Qt:: QueuedConnection);436 this, SLOT(sendResponseIfNeeded()), Qt::DirectConnection); 437 437 438 438 connect(m_reply, SIGNAL(readyRead()), 439 this, SLOT(forwardData()), Qt:: QueuedConnection);439 this, SLOT(forwardData()), Qt::DirectConnection); 440 440 connect(this, SIGNAL(processQueuedItems()), 441 this, SLOT(sendQueuedItems()), Qt:: QueuedConnection);441 this, SLOT(sendQueuedItems()), Qt::DirectConnection); 442 442 } 443 443
Note: See TracChangeset
for help on using the changeset viewer.