Changeset 52115 in webkit

Timestamp:

Dec 14, 2009 1:27:11 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-14 Jakob Petsovits <​jpetsovits@rim.com>

Reviewed by Simon Fraser.

Add FloatQuad::isRectilinear() to check whether it can be represented as FloatRect.
​https://bugs.webkit.org/show_bug.cgi?id=30442

This enables optimizations for distinguishing between
arbitrary FloatQuads and rectilinear ones.

• platform/graphics/FloatQuad.cpp: (WebCore::FloatQuad::isRectilinear):
• platform/graphics/FloatQuad.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/FloatQuad.cpp (modified) (1 diff)
• platform/graphics/FloatQuad.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-14  Jakob Petsovits  <jpetsovits@rim.com>
+
+        Reviewed by Simon Fraser.
+
+        Add FloatQuad::isRectilinear() to check whether it can be represented as FloatRect.
+        https://bugs.webkit.org/show_bug.cgi?id=30442
+
+        This enables optimizations for distinguishing between
+        arbitrary FloatQuads and rectilinear ones.
+
+        * platform/graphics/FloatQuad.cpp:
+        (WebCore::FloatQuad::isRectilinear):
+        * platform/graphics/FloatQuad.h:
+
 2009-12-14  Simon Hausmann  <hausmann@webkit.org>
 

trunk/WebCore/platform/graphics/FloatQuad.cpp

@@ -86 +86 @@
 }
 
+bool FloatQuad::isRectilinear() const
+{
+    return (m_p1.x() == m_p2.x() && m_p2.y() == m_p3.y() && m_p3.x() == m_p4.x() && m_p4.y() == m_p1.y())
+        || (m_p1.y() == m_p2.y() && m_p2.x() == m_p3.x() && m_p3.y() == m_p4.y() && m_p4.x() == m_p1.x());
+}
+
 bool FloatQuad::containsPoint(const FloatPoint& p) const
 {

trunk/WebCore/platform/graphics/FloatQuad.h

@@ -75 +75 @@
     bool isEmpty() const { return boundingBox().isEmpty(); }
 
+    // Tests whether this quad can be losslessly represented by a FloatRect,
+    // that is, if two edges are parallel to the x-axis and the other two
+    // are parallel to the y-axis. If this method returns true, the
+    // corresponding FloatRect can be retrieved with boundingBox().
+    bool isRectilinear() const;
+
     // Tests whether the given point is inside, or on an edge or corner of this quad.
     bool containsPoint(const FloatPoint&) const;