Changeset 52142 in webkit

Timestamp:

Dec 15, 2009 12:57:31 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2009-12-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

scm_unittest.py is too slow
​https://bugs.webkit.org/show_bug.cgi?id=31818

Now we don't run the SCM unit tests unless we get the --all flag on the
command line. Eric and I were commenting out this test because it was
too painful to run.

• Scripts/run-webkit-unittests:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-webkit-unittests (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-12-15  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        scm_unittest.py is too slow
+        https://bugs.webkit.org/show_bug.cgi?id=31818
+
+        Now we don't run the SCM unit tests unless we get the --all flag on the
+        command line.  Eric and I were commenting out this test because it was
+        too painful to run.
+
+        * Scripts/run-webkit-unittests:
+
 2009-12-14  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/run-webkit-unittests

@@ -28 +28 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+import sys
 import unittest
 
@@ -43 +44 @@
 from modules.logging_unittest import *
 from modules.multicommandtool_unittest import *
-from modules.scm_unittest import *
 from modules.webkitport_unittest import *
 from modules.workqueue_unittest import *
 
 if __name__ == "__main__":
+    # FIXME: This is a hack, but I'm tired of commenting out the test.
+    #        See https://bugs.webkit.org/show_bug.cgi?id=31818
+    if len(sys.argv) > 1 and sys.argv[1] == "--all":
+        sys.argv.remove("--all")
+        from modules.scm_unittest import *
+
     unittest.main()