Changeset 52228 in webkit


Ignore:
Timestamp:
Dec 16, 2009 4:40:10 PM (14 years ago)
Author:
eric@webkit.org
Message:

2009-12-16 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

bugzilla-tool should not require users to install mechanize
https://bugs.webkit.org/show_bug.cgi?id=32635

Centralize our import logic.

  • Scripts/modules/bugzilla.py: use webkit_mechanize
  • Scripts/modules/statusbot.py: use webkit_mechanize
  • Scripts/modules/webkit_mechanize.py: Added.
Location:
trunk/WebKitTools
Files:
1 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r52221 r52228  
     12009-12-16  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by David Levin.
     4
     5        bugzilla-tool should not require users to install mechanize
     6        https://bugs.webkit.org/show_bug.cgi?id=32635
     7
     8        Centralize our import logic.
     9
     10        * Scripts/modules/bugzilla.py: use webkit_mechanize
     11        * Scripts/modules/statusbot.py: use webkit_mechanize
     12        * Scripts/modules/webkit_mechanize.py: Added.
     13
    1142009-12-16  Eric Seidel  <eric@webkit.org>
    215
  • trunk/WebKitTools/Scripts/modules/bugzilla.py

    r52135 r52228  
    4545from .BeautifulSoup import BeautifulSoup, SoupStrainer
    4646
    47 try:
    48     from mechanize import Browser
    49 except ImportError, e:
    50     print """
    51 mechanize is required.
    52 
    53 To install:
    54 sudo easy_install mechanize
    55 
    56 Or from the web:
    57 http://wwwsearch.sourceforge.net/mechanize/
    58 """
    59     exit(1)
     47from modules.webkit_mechanize import Browser
    6048
    6149def parse_bug_id(message):
  • trunk/WebKitTools/Scripts/modules/statusbot.py

    r52180 r52228  
    3030
    3131from modules.logging import log
     32from modules.webkit_mechanize import Browser
    3233
    3334# WebKit includes a built copy of BeautifulSoup in Scripts/modules
    3435# so this import should always succeed.
    3536from .BeautifulSoup import BeautifulSoup
    36 
    37 try:
    38     from mechanize import Browser
    39 except ImportError, e:
    40     print """
    41 mechanize is required.
    42 
    43 To install:
    44 sudo easy_install mechanize
    45 
    46 Or from the web:
    47 http://wwwsearch.sourceforge.net/mechanize/
    48 """
    49     exit(1)
    5037
    5138import urllib2
Note: See TracChangeset for help on using the changeset viewer.