Changeset 52275 in webkit

Timestamp:

Dec 17, 2009 12:00:50 PM (14 years ago)

Author:

Adam Roben

Message:

Don't include all JSC headers everywhere

​https://bugs.webkit.org/show_bug.cgi?id=32663

Patch by Benjamin Otte <​otte@gnome.org> on 2009-12-17
Reviewed by Adam Roben.

WebCore:

PlatformString.h included almost all of JSC via runtime/Identifier.h.
This patch gets rid of this include by forward-declaring the required
classes instead.
This reduces the build size of the object files on a Gtk debug build
by 10%. The resulting libwebkit.so gets 5% smaller.

No new tests as it's just a build improvement.

• platform/gtk/LocalizedStringsGtk.cpp:

include math.h here (it used to be pulled by JSC)

• platform/text/PlatformString.h:
• platform/text/String.cpp:

WebKit/win:

• WebCoreLocalizedStrings.cpp: Added now-needed #include of

MathExtras.h.

Location:

trunk

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/gtk/LocalizedStringsGtk.cpp (modified) (1 diff)
• WebCore/platform/text/PlatformString.h (modified) (2 diffs)
• WebCore/platform/text/String.cpp (modified) (1 diff)
• WebKit/win/ChangeLog (modified) (1 diff)
• WebKit/win/WebCoreLocalizedStrings.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-17  Benjamin Otte  <otte@gnome.org>
+
+        Reviewed by Adam Roben.
+
+        Don't include all JSC headers everywhere
+        https://bugs.webkit.org/show_bug.cgi?id=32663
+
+        PlatformString.h included almost all of JSC via runtime/Identifier.h.
+        This patch gets rid of this include by forward-declaring the required
+        classes instead.
+        This reduces the build size of the object files on a Gtk debug build
+        by 10%. The resulting libwebkit.so gets 5% smaller.
+
+        No new tests as it's just a build improvement.
+
+        * platform/gtk/LocalizedStringsGtk.cpp:
+        include math.h here (it used to be pulled by JSC)
+        * platform/text/PlatformString.h:
+        * platform/text/String.cpp:
+
 2009-12-17  Evan Martin  <evan@chromium.org>
 

trunk/WebCore/platform/gtk/LocalizedStringsGtk.cpp

@@ -39 +39 @@
 #include <glib/gi18n-lib.h>
 #include <gtk/gtk.h>
+#include <math.h>
 
 namespace WebCore {

trunk/WebCore/platform/text/PlatformString.h

@@ -32 +32 @@
 #endif
 
-#if USE(JSC)
-#include <runtime/Identifier.h>
-#else
-// runtime/Identifier.h brings in a variety of wtf headers.  We explicitly
-// include them in the case of non-JSC builds to keep things consistent.
 #include <wtf/HashMap.h>
 #include <wtf/HashSet.h>
 #include <wtf/OwnPtr.h>
-#endif
 
 #if PLATFORM(CF)
@@ -59 +53 @@
 #if PLATFORM(HAIKU)
 class BString;
+#endif
+
+#if USE(JSC)
+namespace JSC {
+class Identifier;
+class UString;
+}
 #endif
 

trunk/WebCore/platform/text/String.cpp

@@ -38 +38 @@
 
 #if USE(JSC)
+#include <runtime/Identifier.h>
+
 using JSC::Identifier;
 using JSC::UString;

trunk/WebKit/win/ChangeLog

@@ +1 @@
+2009-12-17  Benjamin Otte  <otte@gnome.org>
+
+        Reviewed by Adam Roben.
+
+        Don't include all JSC headers everywhere
+        https://bugs.webkit.org/show_bug.cgi?id=32663
+
+        * WebCoreLocalizedStrings.cpp: Added now-needed #include of
+        MathExtras.h.
+
 2009-12-17  Adam Roben  <aroben@apple.com>
 

trunk/WebKit/win/WebCoreLocalizedStrings.cpp

@@ -29 +29 @@
 #include <WebCore/LocalizedStrings.h>
 #include <WebCore/PlatformString.h>
+#include <wtf/MathExtras.h>
 #include <wtf/RetainPtr.h>