Changeset 52281 in webkit

Timestamp:

Dec 17, 2009 1:09:37 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-17 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Eric Seidel.

Allow custom memory allocation control for js bindings
​https://bugs.webkit.org/show_bug.cgi?id=32655

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:

class name - instantiated at: WebCore/'location'

class ScriptCachedFrameData - history/CachedFrame.cpp:117
class WebCoreJSClientData - bindings/js/JSDOMWindowBase.cpp:162
class ScheduledAction - bindings/js/ScheduledAction.cpp:58

• bindings/js/JSDOMBinding.h:
• bindings/js/ScheduledAction.h:
• bindings/js/ScriptCachedFrameData.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/JSDOMBinding.h (modified) (1 diff)
• bindings/js/ScheduledAction.h (modified) (1 diff)
• bindings/js/ScriptCachedFrameData.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-17  Zoltan Horvath  <zoltan@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Allow custom memory allocation control for js bindings
+        https://bugs.webkit.org/show_bug.cgi?id=32655
+
+        Inherits the following classes from Noncopyable because these are instantiated 
+        by 'new' and no need to be copyable:
+
+        class name                  - instantiated at:  WebCore/'location'
+
+        class ScriptCachedFrameData - history/CachedFrame.cpp:117
+        class WebCoreJSClientData   - bindings/js/JSDOMWindowBase.cpp:162
+        class ScheduledAction       - bindings/js/ScheduledAction.cpp:58
+
+        * bindings/js/JSDOMBinding.h:
+        * bindings/js/ScheduledAction.h:
+        * bindings/js/ScriptCachedFrameData.h:
+
 2009-12-17  Adam Roben  <aroben@apple.com>
 

trunk/WebCore/bindings/js/JSDOMBinding.h

@@ -183 +183 @@
     };
 
-    class WebCoreJSClientData : public JSC::JSGlobalData::ClientData {
+    class WebCoreJSClientData : public JSC::JSGlobalData::ClientData, public Noncopyable {
         friend class JSGlobalDataWorldIterator;
 

trunk/WebCore/bindings/js/ScheduledAction.h

@@ -41 +41 @@
     * and window.setInterval()
     */
-    class ScheduledAction {
+    class ScheduledAction : public Noncopyable {
     public:
         static ScheduledAction* create(JSC::ExecState*, const JSC::ArgList&, DOMWrapperWorld* isolatedWorld);

trunk/WebCore/bindings/js/ScriptCachedFrameData.h

@@ -41 +41 @@
     class DOMWrapperWorld;
 
-    class ScriptCachedFrameData  {
+    class ScriptCachedFrameData  : public Noncopyable {
         typedef HashMap< RefPtr<DOMWrapperWorld>, JSC::ProtectedPtr<JSDOMWindow> > JSDOMWindowSet;