Changeset 52294 in webkit


Ignore:
Timestamp:
Dec 17, 2009 4:51:13 PM (14 years ago)
Author:
eric@webkit.org
Message:

2009-12-17 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for inspector's classes
https://bugs.webkit.org/show_bug.cgi?id=32660

Inherits the following classes from Noncopyable because these are
instantiated by 'new' and no need to be copyable:

class name - instantiated at: WebCore/'location'

class JavaScriptDebugServer - inspector/JavaScriptDebugServer.cpp:72
class ConsoleMessage - inspector/InspectorController.cpp:329
class InspectorController - page/Page.cpp:119

  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.h:
  • inspector/JavaScriptDebugServer.h:
Location:
trunk/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r52292 r52294  
     12009-12-17  Zoltan Horvath  <zoltan@webkit.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        Allow custom memory allocation control for inspector's classes
     6        https://bugs.webkit.org/show_bug.cgi?id=32660                               
     7
     8        Inherits the following classes from Noncopyable because these are
     9        instantiated by 'new' and no need to be copyable:                                           
     10
     11        class name                  - instantiated at:  WebCore/'location'
     12
     13        class JavaScriptDebugServer - inspector/JavaScriptDebugServer.cpp:72
     14        class ConsoleMessage        - inspector/InspectorController.cpp:329
     15        class InspectorController   - page/Page.cpp:119
     16
     17        * inspector/ConsoleMessage.h:
     18        * inspector/InspectorController.h:
     19        * inspector/JavaScriptDebugServer.h:
     20
    1212009-12-17  Steve Block  <steveblock@google.com>
    222
  • trunk/WebCore/inspector/ConsoleMessage.h

    r50064 r52294  
    4343    class ScriptString;
    4444
    45     class ConsoleMessage {
     45    class ConsoleMessage : public Noncopyable {
    4646    public:
    4747        ConsoleMessage(MessageSource, MessageType, MessageLevel, const String& m, unsigned li, const String& u, unsigned g);       
  • trunk/WebCore/inspector/InspectorController.h

    r51846 r52294  
    9090class InspectorController
    9191#if ENABLE(JAVASCRIPT_DEBUGGER)
    92                           : JavaScriptDebugListener
     92                          : JavaScriptDebugListener, public Noncopyable
     93#else
     94                          : public Noncopyable
    9395#endif
    9496                                                    {
  • trunk/WebCore/inspector/JavaScriptDebugServer.h

    r47919 r52294  
    5353    class JavaScriptDebugListener;
    5454
    55     class JavaScriptDebugServer : JSC::Debugger {
     55    class JavaScriptDebugServer : JSC::Debugger, public Noncopyable {
    5656    public:
    5757        static JavaScriptDebugServer& shared();
Note: See TracChangeset for help on using the changeset viewer.