Changeset 52302 in webkit

Timestamp:

Dec 17, 2009 11:17:12 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-17 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

HTMLInputElement::stepMismatch() uses ambiguous overload of pow()
​https://bugs.webkit.org/show_bug.cgi?id=32675

Use the double constant 2.0 instead of static_cast<double>(2).

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepMismatch):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLInputElement.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-17  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        HTMLInputElement::stepMismatch() uses ambiguous overload of pow()
+        https://bugs.webkit.org/show_bug.cgi?id=32675
+
+        Use the double constant 2.0 instead of static_cast<double>(2).
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::stepMismatch):
+
 2009-12-17  Justin Schuh  <jschuh@chromium.org>
 

trunk/WebCore/html/HTMLInputElement.cpp

@@ -338 +338 @@
         // value is greater than step*2^DBL_MANT_DIG, the following fmod() makes
         // no sense.
-        if (doubleValue / pow(static_cast<double>(2), DBL_MANT_DIG) > step)
+        if (doubleValue / pow(2.0, DBL_MANT_DIG) > step)
             return false;
         double remainder = fmod(doubleValue, step);
         // Accepts errors in lower 7-bit.
-        double acceptableError = step / pow(static_cast<double>(2), DBL_MANT_DIG - 7);
+        double acceptableError = step / pow(2.0, DBL_MANT_DIG - 7);
         return acceptableError < remainder && remainder < (step - acceptableError);
     }