Changeset 52440 in webkit

Timestamp:

Dec 21, 2009 3:10:56 AM (14 years ago)

Author:

pfeldman@chromium.org

Message:

2009-12-20 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Can’t copy outer html of selected node.
Also adds "Copy as HTML" context menu item.

​https://bugs.webkit.org/show_bug.cgi?id=32802

• English.lproj/localizedStrings.js:
• inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
• inspector/front-end/inspector.js: (WebInspector.documentCanCopy):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• English.lproj/localizedStrings.js (modified) (previous)
• inspector/front-end/ElementsTreeOutline.js (modified) (2 diffs)
• inspector/front-end/inspector.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-20  Pavel Feldman  <pfeldman@chromium.org>
+
+        Reviewed by Timothy Hatcher.
+
+        Web Inspector: Can’t copy outer html of selected node.
+        Also adds "Copy as HTML" context menu item.
+
+        https://bugs.webkit.org/show_bug.cgi?id=32802
+
+        * English.lproj/localizedStrings.js:
+        * inspector/front-end/ElementsTreeOutline.js:
+        (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
+        * inspector/front-end/inspector.js:
+        (WebInspector.documentCanCopy):
+
 2009-12-20  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/WebCore/inspector/front-end/ElementsTreeOutline.js

@@ -604 +604 @@
 
         // Add node-related actions.
+        contextMenu.appendItem(WebInspector.UIString("Copy as HTML"), this._copyHTML.bind(this));
         contextMenu.appendItem(WebInspector.UIString("Delete Node"), this.remove.bind(this));
     },
@@ -960 +961 @@
         var callId = WebInspector.Callback.wrap(removeNodeCallback);
         InspectorBackend.removeNode(callId, this.representedObject.id);
+    },
+
+    _copyHTML: function(node)
+    {
+        InspectorBackend.copyNode(this.representedObject.id);
     }
 }

trunk/WebCore/inspector/front-end/inspector.js

@@ -728 +728 @@
 WebInspector.documentCanCopy = function(event)
 {
-    return this.currentPanel && this.currentPanel.handleCopyEvent;
+    if (this.currentPanel && this.currentPanel.handleCopyEvent)
+        event.preventDefault();
 }