Changeset 52534 in webkit


Ignore:
Timestamp:
Dec 23, 2009 4:55:01 PM (14 years ago)
Author:
Nikolas Zimmermann
Message:

2009-12-23 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Eric Seidel.

Reverse JS GenerateConstructor logic
​https://bugs.webkit.org/show_bug.cgi?id=32910

Make 'GenerateConstructor' the default setting for all classes, defined in IDL files. The flag is now obsolete and
can be removed from all IDL files in a follow-up patch. Add new 'OmitConstructor' flag, that allows to restore the
old default behaviour: do not generate JSFoobarConstructor class.

No change in functionality, despite the fact that we're generating a lot more constructors now, as they have to
be exposed through DOMWindow.idl -- this can be done per affected class in follow-up patches. Especially the SVG
classes have to be exposed, most of them are missing JS constructors so far.

As side effect HTMLOptionsCollection is now correctly exposing its constructor, thus fixing a test in fast/dom/wrapper-classes.html

Location:
trunk
Files:
75 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r52533 r52534  
     12009-12-23  Nikolas Zimmermann  <nzimmermann@rim.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Reverse JS GenerateConstructor logic
     6        https://bugs.webkit.org/show_bug.cgi?id=32910
     7
     8        HTMLOptionsCollection correctly exposes its JS constructor now, thus fixing its test in fast/dom/wrapper-classes.html
     9
     10        * fast/dom/wrapper-classes-expected.txt:
     11
    1122009-12-23  Brian Weinstein  <bweinstein@apple.com>
    213

  • trunk/LayoutTests/fast/dom/wrapper-classes-expected.txt

    r50087 r52534  
    143143PASS jsWrapperClass(document.createElement('select').options) is 'HTMLOptionsCollection'
    144144FAIL jsWrapperClass(document.createElement('select').options.__proto__) should be HTMLOptionsCollectionPrototype. Was HTMLCollectionPrototype.
    145 FAIL jsWrapperClass(document.createElement('select').options.constructor) should be HTMLOptionsCollectionConstructor. Was Function.
     145PASS jsWrapperClass(document.createElement('select').options.constructor) is 'HTMLOptionsCollectionConstructor'
    146146
    147147HTML Elements

  • trunk/WebCore/ChangeLog

    r52532 r52534  
     12009-12-23  Nikolas Zimmermann  <nzimmermann@rim.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Reverse JS GenerateConstructor logic
     6        https://bugs.webkit.org/show_bug.cgi?id=32910
     7
     8        Make 'GenerateConstructor' the default setting for all classes, defined in IDL files. The flag is now obsolete and
     9        can be removed from all IDL files in a follow-up patch. Add new 'OmitConstructor' flag, that allows to restore the
     10        old default behaviour: do not generate JSFoobarConstructor class.
     11
     12        No change in functionality, despite the fact that we're generating a lot more constructors now, as they have to
     13        be exposed through DOMWindow.idl -- this can be done per affected class in follow-up patches. Especially the SVG
     14        classes have to be exposed, most of them are missing JS constructors so far.
     15
     16        As side effect HTMLOptionsCollection is now correctly exposing its constructor, thus fixing a test in fast/dom/wrapper-classes.html
     17
     18        * bindings/scripts/CodeGeneratorJS.pm:
     19        * css/CSSUnknownRule.idl:
     20        * css/WebKitCSSMatrix.idl:
     21        * dom/EventListener.idl:
     22        * dom/EventTarget.idl:
     23        * dom/MessageChannel.idl:
     24        * html/TimeRanges.idl:
     25        * html/ValidityState.idl:
     26        * html/VoidCallback.idl:
     27        * html/canvas/CanvasGradient.idl:
     28        * html/canvas/CanvasPattern.idl:
     29        * html/canvas/CanvasPixelArray.idl:
     30        * html/canvas/WebGLActiveInfo.idl:
     31        * html/canvas/WebGLArray.idl:
     32        * html/canvas/WebGLArrayBuffer.idl:
     33        * html/canvas/WebGLBuffer.idl:
     34        * html/canvas/WebGLByteArray.idl:
     35        * html/canvas/WebGLFloatArray.idl:
     36        * html/canvas/WebGLFramebuffer.idl:
     37        * html/canvas/WebGLIntArray.idl:
     38        * html/canvas/WebGLProgram.idl:
     39        * html/canvas/WebGLRenderbuffer.idl:
     40        * html/canvas/WebGLShader.idl:
     41        * html/canvas/WebGLShortArray.idl:
     42        * html/canvas/WebGLTexture.idl:
     43        * html/canvas/WebGLUniformLocation.idl:
     44        * html/canvas/WebGLUnsignedByteArray.idl:
     45        * html/canvas/WebGLUnsignedIntArray.idl:
     46        * html/canvas/WebGLUnsignedShortArray.idl:
     47        * inspector/JavaScriptCallFrame.idl:
     48        * loader/appcache/DOMApplicationCache.idl:
     49        * notifications/Notification.idl:
     50        * notifications/NotificationCenter.idl:
     51        * page/AbstractView.idl:
     52        * page/BarInfo.idl:
     53        * page/Console.idl:
     54        * page/Coordinates.idl:
     55        * page/DOMSelection.idl:
     56        * page/DOMWindow.idl:
     57        * page/EventSource.idl:
     58        * page/Geolocation.idl:
     59        * page/Geoposition.idl:
     60        * page/History.idl:
     61        * page/Location.idl:
     62        * page/Navigator.idl:
     63        * page/Screen.idl:
     64        * page/WebKitPoint.idl:
     65        * page/WorkerNavigator.idl:
     66        * storage/Database.idl:
     67        * storage/SQLError.idl:
     68        * storage/SQLResultSet.idl:
     69        * storage/SQLResultSetRowList.idl:
     70        * storage/SQLTransaction.idl:
     71        * websockets/WebSocket.idl:
     72        * workers/DedicatedWorkerContext.idl:
     73        * workers/SharedWorker.idl:
     74        * workers/SharedWorkerContext.idl:
     75        * workers/Worker.idl:
     76        * workers/WorkerContext.idl:
     77        * xml/XMLHttpRequest.idl:
     78        * xml/XPathNSResolver.idl:
     79        * xml/XSLTProcessor.idl:
     80
    1812009-12-23  Adam Barth  <abarth@webkit.org>
    282

  • trunk/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r52434 r52534  
    577577
    578578    my $hasGetter = $numAttributes > 0
    579                  || $dataNode->extendedAttributes->{"GenerateConstructor"}
     579                 || !$dataNode->extendedAttributes->{"OmitConstructor"}
    580580                 || $dataNode->extendedAttributes->{"HasIndexGetter"}
    581581                 || $dataNode->extendedAttributes->{"HasCustomIndexGetter"}
    … …  
    680680
    681681    # Constructor object getter
    682     push(@headerContent, "    static JSC::JSValue getConstructor(JSC::ExecState*, JSC::JSGlobalObject*);\n") if $dataNode->extendedAttributes->{"GenerateConstructor"};
     682    push(@headerContent, "    static JSC::JSValue getConstructor(JSC::ExecState*, JSC::JSGlobalObject*);\n") if !$dataNode->extendedAttributes->{"OmitConstructor"};
    683683
    684684    my $numCustomFunctions = 0;
    … …  
    863863    }
    864864
    865     if ($numAttributes > 0 || $dataNode->extendedAttributes->{"GenerateConstructor"}) {
     865    if ($numAttributes > 0 || !$dataNode->extendedAttributes->{"OmitConstructor"}) {
    866866        push(@headerContent,"// Attributes\n\n");
    867867        foreach my $attribute (@{$dataNode->attributes}) {
    … …  
    874874        }
    875875       
    876         if ($dataNode->extendedAttributes->{"GenerateConstructor"}) {
     876        if (!$dataNode->extendedAttributes->{"OmitConstructor"}) {
    877877            my $getter = "js" . $interfaceName . "Constructor";
    878878            push(@headerContent, "JSC::JSValue ${getter}(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&);\n");
    … …  
    943943    # - Add all attributes in a hashtable definition
    944944    my $numAttributes = @{$dataNode->attributes};
    945     $numAttributes++ if $dataNode->extendedAttributes->{"GenerateConstructor"};
     945    $numAttributes++ if !$dataNode->extendedAttributes->{"OmitConstructor"};
    946946
    947947    if ($numAttributes > 0) {
    … …  
    984984        }
    985985
    986         if ($dataNode->extendedAttributes->{"GenerateConstructor"}) {
     986        if (!$dataNode->extendedAttributes->{"OmitConstructor"}) {
    987987            push(@hashKeys, "constructor");
    988988            my $getter = "js" . $interfaceName . "Constructor";
    … …  
    10021002
    10031003    # - Add all constants
    1004     if ($dataNode->extendedAttributes->{"GenerateConstructor"}) {
     1004    if (!$dataNode->extendedAttributes->{"OmitConstructor"}) {
    10051005        $hashSize = $numConstants;
    10061006        $hashName = $className . "ConstructorTable";
    … …  
    12401240
    12411241    my $hasGetter = $numAttributes > 0
    1242                  || $dataNode->extendedAttributes->{"GenerateConstructor"}
     1242                 || !$dataNode->extendedAttributes->{"OmitConstructor"}
    12431243                 || $dataNode->extendedAttributes->{"HasIndexGetter"}
    12441244                 || $dataNode->extendedAttributes->{"HasCustomIndexGetter"}
    … …  
    13911391            }
    13921392
    1393             if ($dataNode->extendedAttributes->{"GenerateConstructor"}) {
     1393            if (!$dataNode->extendedAttributes->{"OmitConstructor"}) {
    13941394                my $constructorFunctionName = "js" . $interfaceName . "Constructor";
    13951395
    … …  
    15491549    }
    15501550
    1551     if ($dataNode->extendedAttributes->{"GenerateConstructor"}) {
     1551    if (!$dataNode->extendedAttributes->{"OmitConstructor"}) {
    15521552        push(@implContent, "JSValue ${className}::getConstructor(ExecState* exec, JSGlobalObject* globalObject)\n{\n");
    15531553        push(@implContent, "    return getDOMConstructor<${className}Constructor>(exec, static_cast<JSDOMGlobalObject*>(globalObject));\n");

  • trunk/WebCore/css/CSSUnknownRule.idl

    r29672 r52534  
    2424    interface [
    2525        InterfaceUUID=35670098-b732-419c-b7cd-dc0d5e26d5e3,
    26         ImplementationUUID=4b755f87-2509-4b98-a953-8ecb88fe4b21
     26        ImplementationUUID=4b755f87-2509-4b98-a953-8ecb88fe4b21,
     27        OmitConstructor
    2728    ] CSSUnknownRule : CSSRule {
    2829    };

  • trunk/WebCore/css/WebKitCSSMatrix.idl

    r40807 r52534  
    2727
    2828    // Introduced in DOM Level ?:
    29     interface WebKitCSSMatrix {
     29    interface [OmitConstructor] WebKitCSSMatrix {
    3030
    3131        // These attributes are simple aliases for certain elements of the 4x4 matrix

  • trunk/WebCore/dom/EventListener.idl

    r48884 r52534  
    2626        ObjCProtocol,
    2727        PureInterface,
     28        OmitConstructor,
    2829        InterfaceUUID=B04F2AE3-71E2-4ebe-ABFE-EF4938354082,
    2930    ] EventListener {

  • trunk/WebCore/dom/EventTarget.idl

    r40672 r52534  
    2525        ObjCProtocol,
    2626        PureInterface,
     27        OmitConstructor
    2728        InterfaceUUID=1D71C7EC-0BA0-4044-BDFD-56B3E8F5F9D4
    2829    ] EventTarget {

  • trunk/WebCore/dom/MessageChannel.idl

    r37784 r52534  
    2727module events {
    2828
    29     interface [CustomMarkFunction, NoStaticTables] MessageChannel {
     29    interface [CustomMarkFunction, NoStaticTables, OmitConstructor] MessageChannel {
    3030
    3131        readonly attribute MessagePort port1;

  • trunk/WebCore/html/TimeRanges.idl

    r46900 r52534  
    2626module html {
    2727
    28 interface [Conditional=VIDEO] TimeRanges {
     28interface [Conditional=VIDEO, OmitConstructor] TimeRanges {
    2929    readonly attribute unsigned long length;
    3030    float start(in unsigned long index)

  • trunk/WebCore/html/ValidityState.idl

    r45895 r52534  
    2323module html {
    2424
    25     interface ValidityState {
     25    interface [OmitConstructor] ValidityState {
    2626        readonly attribute boolean         valueMissing;
    2727        readonly attribute boolean         typeMismatch;

  • trunk/WebCore/html/VoidCallback.idl

    r29672 r52534  
    2525
    2626module html {
    27     interface [CustomNativeConverter] VoidCallback {
     27    interface [CustomNativeConverter, OmitConstructor] VoidCallback {
    2828        void handleEvent();
    2929    };

  • trunk/WebCore/html/canvas/CanvasGradient.idl

    r49734 r52534  
    2828    interface [
    2929        InterfaceUUID=bb1108ea-6b8c-4a08-894a-218628630cdb,
    30         ImplementationUUID=a2942ae6-2731-4286-98cc-9d5e79e20de1
     30        ImplementationUUID=a2942ae6-2731-4286-98cc-9d5e79e20de1,
     31        OmitConstructor
    3132    ] CanvasGradient {
    3233

  • trunk/WebCore/html/canvas/CanvasPattern.idl

    r49734 r52534  
    2828    interface [
    2929        InterfaceUUID=c2131348-6d8c-47b5-86cc-d41aff34ce15,
    30         ImplementationUUID=82f5d713-3d17-44dd-aa4a-7766fe345940
     30        ImplementationUUID=82f5d713-3d17-44dd-aa4a-7766fe345940,
     31        OmitConstructor
    3132    ] CanvasPattern {
    3233

  • trunk/WebCore/html/canvas/CanvasPixelArray.idl

    r49734 r52534  
    3030#if !defined(LANGUAGE_JAVASCRIPT) || !LANGUAGE_JAVASCRIPT || defined(V8_BINDING) && V8_BINDING
    3131    interface [
     32        OmitConstructor,
    3233        CustomHeader,
    3334        HasNumericIndexGetter,

  • trunk/WebCore/html/canvas/WebGLActiveInfo.idl

    r50725 r52534  
    2828    interface [
    2929        Conditional=3D_CANVAS,
     30        OmitConstructor
    3031    ] WebGLActiveInfo {
    3132        readonly attribute int size;

  • trunk/WebCore/html/canvas/WebGLArray.idl

    r51049 r52534  
    2525
    2626module html {
    27     interface [Conditional=3D_CANVAS, CustomToJS] WebGLArray {
     27    interface [Conditional=3D_CANVAS, CustomToJS, OmitConstructor] WebGLArray {
    2828        readonly attribute WebGLArrayBuffer buffer;
    2929        readonly attribute unsigned long byteOffset;

  • trunk/WebCore/html/canvas/WebGLArrayBuffer.idl

    r50725 r52534  
    2525
    2626module html {
    27     interface [Conditional=3D_CANVAS] WebGLArrayBuffer {
     27    interface [Conditional=3D_CANVAS, OmitConstructor] WebGLArrayBuffer {
    2828        readonly attribute int byteLength;
    2929    };

  • trunk/WebCore/html/canvas/WebGLBuffer.idl

    r50725 r52534  
    2525
    2626module html {
    27     interface [Conditional=3D_CANVAS] WebGLBuffer {
     27    interface [Conditional=3D_CANVAS, OmitConstructor] WebGLBuffer {
    2828    };
    2929}

  • trunk/WebCore/html/canvas/WebGLByteArray.idl

    r51049 r52534  
    3131        HasCustomIndexSetter,
    3232        GenerateNativeConverter,
    33         GenerateCustomConstructor,
     33        OmitConstructor,
    3434        CustomToJS
    3535    ] WebGLByteArray : WebGLArray {

  • trunk/WebCore/html/canvas/WebGLFloatArray.idl

    r52058 r52534  
    3131        HasCustomIndexSetter,
    3232        GenerateNativeConverter,
    33         GenerateCustomConstructor,
     33        OmitConstructor,
    3434        CustomToJS
    3535    ] WebGLFloatArray : WebGLArray {

  • trunk/WebCore/html/canvas/WebGLFramebuffer.idl

    r50725 r52534  
    2525
    2626module html {
    27     interface [Conditional=3D_CANVAS] WebGLFramebuffer {
     27    interface [Conditional=3D_CANVAS, OmitConstructor] WebGLFramebuffer {
    2828    };
    2929}

  • trunk/WebCore/html/canvas/WebGLIntArray.idl

    r51049 r52534  
    3131        HasCustomIndexSetter,
    3232        GenerateNativeConverter,
    33         GenerateCustomConstructor,
     33        OmitConstructor,
    3434        CustomToJS
    3535    ] WebGLIntArray : WebGLArray {

  • trunk/WebCore/html/canvas/WebGLProgram.idl

    r50725 r52534  
    2525
    2626module html {
    27     interface [Conditional=3D_CANVAS] WebGLProgram {
     27    interface [Conditional=3D_CANVAS, OmitConstructor] WebGLProgram {
    2828    };
    2929}

  • trunk/WebCore/html/canvas/WebGLRenderbuffer.idl

    r50725 r52534  
    2525
    2626module html {
    27     interface [Conditional=3D_CANVAS] WebGLRenderbuffer {
     27    interface [Conditional=3D_CANVAS, OmitConstructor] WebGLRenderbuffer {
    2828    };
    2929}

  • trunk/WebCore/html/canvas/WebGLShader.idl

    r50725 r52534  
    2525
    2626module html {
    27     interface [Conditional=3D_CANVAS] WebGLShader {
     27    interface [Conditional=3D_CANVAS, OmitConstructor] WebGLShader {
    2828    };
    2929}

  • trunk/WebCore/html/canvas/WebGLShortArray.idl

    r51049 r52534  
    3030        HasCustomIndexSetter,
    3131        GenerateNativeConverter,
    32         GenerateCustomConstructor,
     32        OmitConstructor,
    3333        CustomToJS
    3434    ] WebGLShortArray : WebGLArray {

  • trunk/WebCore/html/canvas/WebGLTexture.idl

    r50725 r52534  
    2525
    2626module html {
    27     interface [Conditional=3D_CANVAS] WebGLTexture {
     27    interface [Conditional=3D_CANVAS, OmitConstructor] WebGLTexture {
    2828    };
    2929}

  • trunk/WebCore/html/canvas/WebGLUniformLocation.idl

    r51884 r52534  
    2626
    2727module html {
    28     interface [Conditional=3D_CANVAS] WebGLUniformLocation {
     28    interface [Conditional=3D_CANVAS, OmitConstructor] WebGLUniformLocation {
    2929    };
    3030}

  • trunk/WebCore/html/canvas/WebGLUnsignedByteArray.idl

    r51049 r52534  
    3131        HasCustomIndexSetter,
    3232        GenerateNativeConverter,
    33         GenerateCustomConstructor,
     33        OmitConstructor,
    3434        CustomToJS
    3535    ] WebGLUnsignedByteArray : WebGLArray {

  • trunk/WebCore/html/canvas/WebGLUnsignedIntArray.idl

    r52058 r52534  
    3131        HasCustomIndexSetter,
    3232        GenerateNativeConverter,
    33         GenerateCustomConstructor,
     33        OmitConstructor,
    3434        CustomToJS
    3535    ] WebGLUnsignedIntArray : WebGLArray {

  • trunk/WebCore/html/canvas/WebGLUnsignedShortArray.idl

    r51049 r52534  
    3131        HasCustomIndexSetter,
    3232        GenerateNativeConverter,
    33         GenerateCustomConstructor,
     33        OmitConstructor,
    3434        CustomToJS
    3535    ] WebGLUnsignedShortArray : WebGLArray {

  • trunk/WebCore/inspector/JavaScriptCallFrame.idl

    r43761 r52534  
    2626module inspector {
    2727
    28     interface [Conditional=JAVASCRIPT_DEBUGGER] JavaScriptCallFrame {
     28    interface [Conditional=JAVASCRIPT_DEBUGGER, OmitConstructor] JavaScriptCallFrame {
    2929        [Custom] void evaluate(in DOMString script);
    3030

  • trunk/WebCore/loader/appcache/DOMApplicationCache.idl

    r48701 r52534  
    2828    interface [
    2929        Conditional=OFFLINE_WEB_APPLICATIONS,
    30         EventTarget
     30        EventTarget,
     31        OmitConstructor
    3132    ] DOMApplicationCache {
    3233        // update status

  • trunk/WebCore/notifications/Notification.idl

    r48701 r52534  
    3333    interface [
    3434        Conditional=NOTIFICATIONS,
    35         EventTarget
     35        EventTarget,
     36        OmitConstructor
    3637    ] Notification {
    3738        void show();

  • trunk/WebCore/notifications/NotificationCenter.idl

    r47492 r52534  
    3232
    3333    interface [
    34         Conditional=NOTIFICATIONS
     34        Conditional=NOTIFICATIONS,
     35        OmitConstructor
    3536    ] NotificationCenter {
    3637       [V8Custom] Notification createHTMLNotification(in DOMString url) raises(Exception);

  • trunk/WebCore/page/AbstractView.idl

    r46874 r52534  
    2929    // Introduced in DOM Level 2:
    3030    interface [
    31         ObjCCustomImplementation
     31        ObjCCustomImplementation,
     32        OmitConstructor
    3233    ] AbstractView {
    3334        readonly attribute Document document;

  • trunk/WebCore/page/BarInfo.idl

    r29672 r52534  
    2929module window {
    3030
    31     interface BarInfo {
     31    interface [OmitConstructor] BarInfo {
    3232        readonly attribute boolean visible;
    3333    };

  • trunk/WebCore/page/Console.idl

    r51153 r52534  
    2929module window {
    3030
    31     interface Console {
     31    interface [OmitConstructor] Console {
    3232
    3333#if defined(ENABLE_JAVASCRIPT_DEBUGGER) && ENABLE_JAVASCRIPT_DEBUGGER

  • trunk/WebCore/page/Coordinates.idl

    r48252 r52534  
    2626module core {
    2727
    28     interface Coordinates {
     28    interface [OmitConstructor] Coordinates {
    2929        readonly attribute double latitude;
    3030        readonly attribute double longitude;

  • trunk/WebCore/page/DOMSelection.idl

    r43528 r52534  
    3232    // This is based off of Mozilla's Selection interface
    3333    // https://developer.mozilla.org/En/DOM/Selection
    34     interface DOMSelection {
     34    interface [OmitConstructor] DOMSelection {
    3535        readonly attribute Node anchorNode;
    3636        readonly attribute long anchorOffset;

  • trunk/WebCore/page/DOMWindow.idl

    r52507 r52534  
    3939        CustomPutFunction,
    4040        EventTarget,
     41        OmitConstructor,
    4142        ExtendsDOMGlobalObject,
    4243        GenerateNativeConverter,

  • trunk/WebCore/page/EventSource.idl

    r48701 r52534  
    3535        Conditional=EVENTSOURCE,
    3636        EventTarget,
     37        OmitConstructor,
    3738        NoStaticTables
    3839    ] EventSource {

  • trunk/WebCore/page/Geolocation.idl

    r44094 r52534  
    2626module core {
    2727
    28     interface Geolocation {
     28    interface [OmitConstructor] Geolocation {
    2929        readonly attribute Geoposition lastPosition;
    3030

  • trunk/WebCore/page/Geoposition.idl

    r48252 r52534  
    2626module core {
    2727
    28     interface Geoposition {
     28    interface [OmitConstructor] Geoposition {
    2929        readonly attribute Coordinates coords;
    3030        readonly attribute DOMTimeStamp timestamp;

  • trunk/WebCore/page/History.idl

    r51644 r52534  
    3333        DelegatingPutFunction,
    3434        CustomDeleteProperty,
    35         CustomGetPropertyNames
     35        CustomGetPropertyNames,
     36        OmitConstructor
    3637    ] History {
    3738        readonly attribute unsigned long length;

  • trunk/WebCore/page/Location.idl

    r44677 r52534  
    3939        CustomDefineGetter,
    4040        DelegatingPrototypePutFunction,
    41         CustomPrototypeDefineGetter
     41        CustomPrototypeDefineGetter,
     42        OmitConstructor
    4243    ] Location {
    4344                 attribute [DoNotCheckDomainSecurityOnSet, CustomSetter, V8DisallowShadowing] DOMString href;

  • trunk/WebCore/page/Navigator.idl

    r50477 r52534  
    2121
    2222    interface [
    23         CustomMarkFunction
     23        CustomMarkFunction,
     24        OmitConstructor
    2425    ] Navigator {
    2526        readonly attribute DOMString appCodeName;

  • trunk/WebCore/page/Screen.idl

    r29672 r52534  
    3030module window {
    3131
    32     interface Screen {
     32    interface [OmitConstructor] Screen {
    3333        readonly attribute unsigned long height;
    3434        readonly attribute unsigned long width;

  • trunk/WebCore/page/WebKitPoint.idl

    r41218 r52534  
    2626module window {
    2727
    28     interface WebKitPoint {
     28    interface [OmitConstructor] WebKitPoint {
    2929        attribute float x;
    3030        attribute float y;

  • trunk/WebCore/page/WorkerNavigator.idl

    r39138 r52534  
    3131    interface [
    3232        Conditional=WORKERS,
    33         NoStaticTables
     33        NoStaticTables,
     34        OmitConstructor
    3435    ] WorkerNavigator {
    3536        readonly attribute DOMString appName;

  • trunk/WebCore/storage/Database.idl

    r48227 r52534  
    3030
    3131    interface [
    32         Conditional=DATABASE
     32        Conditional=DATABASE,
     33        OmitConstructor
    3334    ] Database {
    3435        readonly attribute DOMString version;

  • trunk/WebCore/storage/SQLError.idl

    r43699 r52534  
    3030
    3131    interface [
    32         Conditional=DATABASE
     32        Conditional=DATABASE,
     33        OmitConstructor
    3334    ] SQLError {
    3435        readonly attribute unsigned long code;

  • trunk/WebCore/storage/SQLResultSet.idl

    r43699 r52534  
    3030
    3131    interface [
    32         Conditional=DATABASE
     32        Conditional=DATABASE,
     33        OmitConstructor
    3334    ] SQLResultSet {
    3435        readonly attribute SQLResultSetRowList rows;

  • trunk/WebCore/storage/SQLResultSetRowList.idl

    r43699 r52534  
    3030
    3131    interface [
    32         Conditional=DATABASE
     32        Conditional=DATABASE,
     33        OmitConstructor
    3334    ] SQLResultSetRowList {
    3435        readonly attribute unsigned long length;

  • trunk/WebCore/storage/SQLTransaction.idl

    r43283 r52534  
    3030
    3131    interface [
    32         Conditional=DATABASE
     32        Conditional=DATABASE,
     33        OmitConstructor
    3334    ] SQLTransaction {
    3435        [Custom] void executeSql(in DOMString sqlStatement, in ObjectArray arguments, in SQLStatementCallback callback, in SQLStatementErrorCallback errorCallback);

  • trunk/WebCore/svg/ElementTimeControl.idl

    r48311 r52534  
    2727module svg {
    2828
    29     interface [Conditional=SVG, ObjCProtocol] ElementTimeControl {
     29    interface [Conditional=SVG, ObjCProtocol, OmitConstructor] ElementTimeControl {
    3030        void beginElement();
    3131        void beginElementAt(in float offset);

  • trunk/WebCore/svg/SVGAnimationElement.idl

    r31817 r52534  
    2626module svg {
    2727
    28     interface [Conditional=SVG_ANIMATION] SVGAnimationElement : SVGElement,
     28    interface [Conditional=SVG_ANIMATION, OmitConstructor] SVGAnimationElement : SVGElement,
    2929                                                      SVGTests,
    3030                                                      SVGExternalResourcesRequired,

  • trunk/WebCore/svg/SVGExternalResourcesRequired.idl

    r29672 r52534  
    2727module svg {
    2828
    29     interface [Conditional=SVG, ObjCProtocol] SVGExternalResourcesRequired {
     29    interface [Conditional=SVG, ObjCProtocol, OmitConstructor] SVGExternalResourcesRequired {
    3030        readonly attribute SVGAnimatedBoolean externalResourcesRequired;
    3131    };

  • trunk/WebCore/svg/SVGFitToViewBox.idl

    r29672 r52534  
    2727module svg {
    2828
    29     interface [Conditional=SVG, ObjCProtocol] SVGFitToViewBox {
     29    interface [Conditional=SVG, ObjCProtocol, OmitConstructor] SVGFitToViewBox {
    3030        readonly attribute SVGAnimatedRect                viewBox;
    3131        readonly attribute SVGAnimatedPreserveAspectRatio preserveAspectRatio;

  • trunk/WebCore/svg/SVGLangSpace.idl

    r29672 r52534  
    2727module svg {
    2828
    29     interface [Conditional=SVG, ObjCProtocol] SVGLangSpace {
     29    interface [Conditional=SVG, ObjCProtocol, OmitConstructor] SVGLangSpace {
    3030                 attribute core::DOMString xmllang
    3131                     /*setter raises(DOMException)*/;

  • trunk/WebCore/svg/SVGLocatable.idl

    r29672 r52534  
    2727module svg {
    2828
    29     interface [Conditional=SVG, ObjCProtocol] SVGLocatable {
     29    interface [Conditional=SVG, ObjCProtocol, OmitConstructor] SVGLocatable {
    3030        readonly attribute SVGElement nearestViewportElement;
    3131        readonly attribute SVGElement farthestViewportElement;

  • trunk/WebCore/svg/SVGStylable.idl

    r29672 r52534  
    2828module svg {
    2929
    30     interface [Conditional=SVG, ObjCProtocol] SVGStylable {
     30    interface [Conditional=SVG, ObjCProtocol, OmitConstructor] SVGStylable {
    3131        readonly attribute SVGAnimatedString className;
    3232        readonly attribute css::CSSStyleDeclaration style;

  • trunk/WebCore/svg/SVGTests.idl

    r29672 r52534  
    2727module svg {
    2828
    29     interface [Conditional=SVG, ObjCProtocol] SVGTests {
     29    interface [Conditional=SVG, ObjCProtocol, OmitConstructor] SVGTests {
    3030        readonly attribute SVGStringList requiredFeatures;
    3131        readonly attribute SVGStringList requiredExtensions;

  • trunk/WebCore/svg/SVGTransformable.idl

    r29672 r52534  
    2727module svg {
    2828
    29     interface [Conditional=SVG, ObjCProtocol] SVGTransformable : SVGLocatable {
     29    interface [Conditional=SVG, ObjCProtocol, OmitConstructor] SVGTransformable : SVGLocatable {
    3030        readonly attribute SVGAnimatedTransformList transform;
    3131    };

  • trunk/WebCore/svg/SVGURIReference.idl

    r29672 r52534  
    2727module svg {
    2828
    29     interface [Conditional=SVG, ObjCProtocol] SVGURIReference {
     29    interface [Conditional=SVG, ObjCProtocol, OmitConstructor] SVGURIReference {
    3030        readonly attribute SVGAnimatedString href;
    3131    };

  • trunk/WebCore/websockets/WebSocket.idl

    r49488 r52534  
    3434        Conditional=WEB_SOCKETS,
    3535        EventTarget,
    36         NoStaticTables
     36        NoStaticTables,
     37        OmitConstructor
    3738    ] WebSocket {
    3839        readonly attribute DOMString URL;

  • trunk/WebCore/workers/DedicatedWorkerContext.idl

    r49214 r52534  
    3636        IsWorkerContext,
    3737        GenerateNativeConverter,
    38         NoStaticTables
     38        NoStaticTables,
     39        OmitConstructor
    3940    ] DedicatedWorkerContext : WorkerContext {
    4041

  • trunk/WebCore/workers/SharedWorker.idl

    r48705 r52534  
    3535        CustomMarkFunction,
    3636        GenerateNativeConverter,
    37         GenerateToJS
     37        GenerateToJS,
     38        OmitConstructor
    3839    ] SharedWorker : AbstractWorker {
    3940        readonly attribute MessagePort port;

  • trunk/WebCore/workers/SharedWorkerContext.idl

    r48701 r52534  
    3636        IsWorkerContext,
    3737        GenerateNativeConverter,
    38         NoStaticTables
     38        NoStaticTables,
     39        OmitConstructor
    3940    ] SharedWorkerContext : WorkerContext {
    4041

  • trunk/WebCore/workers/Worker.idl

    r49734 r52534  
    3030        Conditional=WORKERS,
    3131        GenerateNativeConverter,
    32         GenerateToJS
     32        GenerateToJS,
     33        OmitConstructor
    3334    ] Worker : AbstractWorker {
    3435

  • trunk/WebCore/workers/WorkerContext.idl

    r49893 r52534  
    3535        IsWorkerContext,
    3636        LegacyParent=JSWorkerContextBase,
    37         NoStaticTables
     37        NoStaticTables,
     38        OmitConstructor
    3839    ] WorkerContext {
    3940

  • trunk/WebCore/xml/XMLHttpRequest.idl

    r48701 r52534  
    3232        CustomMarkFunction,
    3333        EventTarget,
    34         NoStaticTables
     34        NoStaticTables,
     35        OmitConstructor
    3536    ] XMLHttpRequest {
    3637        // From XMLHttpRequestEventTarget

  • trunk/WebCore/xml/XPathNSResolver.idl

    r29672 r52534  
    2121module xpath {
    2222
    23     interface [ObjCProtocol, Conditional=XPATH] XPathNSResolver {
     23    interface [ObjCProtocol, Conditional=XPATH, OmitConstructor] XPathNSResolver {
    2424        [ConvertNullStringTo=Null] DOMString lookupNamespaceURI(in DOMString prefix);
    2525    };

  • trunk/WebCore/xml/XSLTProcessor.idl

    r32795 r52534  
    3434
    3535    interface [
    36         Conditional=XSLT
     36        Conditional=XSLT,
     37        OmitConstructor
    3738    ] XSLTProcessor {
    3839       
Note: See TracChangeset for help on using the changeset viewer.