Changeset 52618 in webkit

Timestamp:

Dec 29, 2009 5:21:55 AM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-29 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
​https://bugs.webkit.org/show_bug.cgi?id=33003

No new tests as there is no new functionality.

• editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
• page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::sendTransitionEvent):
• page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::sendAnimationEvent):
• rendering/RenderSVGContainer.h: (WebCore::toRenderSVGContainer):
• rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow):
• svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::setup):
• svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/CompositeEditCommand.cpp (modified) (1 diff)
• page/animation/ImplicitAnimation.cpp (modified) (1 diff)
• page/animation/KeyframeAnimation.cpp (modified) (1 diff)
• rendering/RenderSVGContainer.h (modified) (2 diffs)
• rendering/style/RenderStyle.cpp (modified) (1 diff)
• svg/graphics/SVGPaintServerGradient.cpp (modified) (1 diff)
• svg/graphics/SVGPaintServerPattern.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
+
+        Reviewed by Eric Seidel.
+
+        Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
+        https://bugs.webkit.org/show_bug.cgi?id=33003
+
+        No new tests as there is no new functionality.
+
+        * editing/CompositeEditCommand.cpp:
+        (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
+        * page/animation/ImplicitAnimation.cpp:
+        (WebCore::ImplicitAnimation::sendTransitionEvent):
+        * page/animation/KeyframeAnimation.cpp:
+        (WebCore::KeyframeAnimation::sendAnimationEvent):
+        * rendering/RenderSVGContainer.h:
+        (WebCore::toRenderSVGContainer):
+        * rendering/style/RenderStyle.cpp:
+        (WebCore::RenderStyle::setTextShadow):
+        * svg/graphics/SVGPaintServerGradient.cpp:
+        (WebCore::SVGPaintServerGradient::setup):
+        * svg/graphics/SVGPaintServerPattern.cpp:
+        (WebCore::SVGPaintServerPattern::setup):
+
 2009-12-28  Andrei Popescu  <andreip@google.com>
 

trunk/WebCore/editing/CompositeEditCommand.cpp

@@ -1091 +1091 @@
     Position caretPos(caret.deepEquivalent());
     // A line break is either a br or a preserved newline.
-    ASSERT(caretPos.node()->hasTagName(brTag) || caretPos.node()->isTextNode() && caretPos.node()->renderer()->style()->preserveNewline());
+    ASSERT(caretPos.node()->hasTagName(brTag) || (caretPos.node()->isTextNode() && caretPos.node()->renderer()->style()->preserveNewline()));
     
     if (caretPos.node()->hasTagName(brTag)) {

trunk/WebCore/page/animation/ImplicitAnimation.cpp

@@ -162 +162 @@
                 element = static_cast<Element*>(m_object->node());
 
-            ASSERT(!element || element->document() && !element->document()->inPageCache());
+            ASSERT(!element || (element->document() && !element->document()->inPageCache()));
             if (!element)
                 return false;

trunk/WebCore/page/animation/KeyframeAnimation.cpp

@@ -282 +282 @@
             element = static_cast<Element*>(m_object->node());
 
-        ASSERT(!element || element->document() && !element->document()->inPageCache());
+        ASSERT(!element || (element->document() && !element->document()->inPageCache()));
         if (!element)
             return false;

trunk/WebCore/rendering/RenderSVGContainer.h

@@ -79 +79 @@
 {
     // Note: isSVGContainer is also true for RenderSVGViewportContainer, which is not derived from this.
-    ASSERT(!object || object->isSVGContainer() && strcmp(object->renderName(), "RenderSVGViewportContainer"));
+    ASSERT(!object || (object->isSVGContainer() && strcmp(object->renderName(), "RenderSVGViewportContainer")));
     return static_cast<RenderSVGContainer*>(object);
 }
@@ -86 +86 @@
 {
     // Note: isSVGContainer is also true for RenderSVGViewportContainer, which is not derived from this.
-    ASSERT(!object || object->isSVGContainer() && strcmp(object->renderName(), "RenderSVGViewportContainer"));
+    ASSERT(!object || (object->isSVGContainer() && strcmp(object->renderName(), "RenderSVGViewportContainer")));
     return static_cast<const RenderSVGContainer*>(object);
 }

trunk/WebCore/rendering/style/RenderStyle.cpp

@@ -703 +703 @@
 void RenderStyle::setTextShadow(ShadowData* val, bool add)
 {
-    ASSERT(!val || !val->spread && val->style == Normal);
+    ASSERT(!val || (!val->spread && val->style == Normal));
 
     StyleRareInheritedData* rareData = rareInheritedData.access();

trunk/WebCore/svg/graphics/SVGPaintServerGradient.cpp

@@ -194 +194 @@
     bool isStroked = (type & ApplyToStrokeTargetType) && style->hasStroke();
 
-    ASSERT(isFilled && !isStroked || !isFilled && isStroked);
+    ASSERT((isFilled && !isStroked) || (!isFilled && isStroked));
 
     context->save();

trunk/WebCore/svg/graphics/SVGPaintServerPattern.cpp

@@ -104 +104 @@
     bool isStroked = (type & ApplyToStrokeTargetType) && style->hasStroke();
 
-    ASSERT(isFilled && !isStroked || !isFilled && isStroked);
+    ASSERT((isFilled && !isStroked) || (!isFilled && isStroked));
 
     m_ownerElement->buildPattern(targetRect);