Changeset 52623 in webkit

Timestamp:

Dec 29, 2009 8:51:14 AM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-29 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Discard port from cookie domain when matching cookies.

WebKit cookies do not hold the port information, so we should match only hostnames.
​https://bugs.webkit.org/show_bug.cgi?id=31787

• inspector/front-end/inspector.js: (WebInspector.updateResource):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/inspector.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-29  Alexander Pavlov  <apavlov@chromium.org>
+
+        Reviewed by Timothy Hatcher.
+
+        Discard port from cookie domain when matching cookies.
+
+        WebKit cookies do not hold the port information, so we should match only hostnames.
+        https://bugs.webkit.org/show_bug.cgi?id=31787
+
+        * inspector/front-end/inspector.js:
+        (WebInspector.updateResource):
+
 2009-12-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 

trunk/WebCore/inspector/front-end/inspector.js

@@ -986 +986 @@
             this.mainResource = resource;
 
-        var match = payload.documentURL.match(/^(http[s]?|file):\/\/([\/]*[^\/]+)/i);
-        if (match)
-            this.addCookieDomain(match[1].toLowerCase() === "file" ? "" : match[2]);
+        var match = payload.documentURL.match(WebInspector.URLRegExp);
+        if (match) {
+            var protocol = match[1].toLowerCase();
+            if (protocol.indexOf("http") === 0 || protocol === "file")
+                this.addCookieDomain(protocol === "file" ? "" : match[2]);
+        }
     }