Changeset 52629 in webkit
- Timestamp:
- Dec 29, 2009 11:55:59 AM (14 years ago)
- Location:
- trunk/WebCore
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r52627 r52629 1 2009-12-29 Alexander Pavlov <apavlov@chromium.org> 2 3 Reviewed by Pavel Feldman. 4 5 Fix UI nits in the Audits panel. 6 https://bugs.webkit.org/show_bug.cgi?id=32932 7 8 * inspector/front-end/AuditLauncherView.js: 9 (WebInspector.AuditLauncherView.prototype._selectAllClicked): 10 (WebInspector.AuditLauncherView.prototype._createCategoryElement): 11 (WebInspector.AuditLauncherView.prototype._createLauncherUI.handleSelectAllClick): 12 (WebInspector.AuditLauncherView.prototype._createLauncherUI): 13 * inspector/front-end/AuditResultView.js: 14 (WebInspector.AuditResultView): 15 (WebInspector.AuditRuleResultPane): 16 * inspector/front-end/audits.css: 17 1 18 2009-12-29 Johnny Ding <jnd@chromium.org> 2 19 -
trunk/WebCore/inspector/front-end/AuditLauncherView.js
r52558 r52629 104 104 }, 105 105 106 _selectAllClicked: function(event) 107 { 108 var shouldCheckCategoriesOn = event.target.checked; 106 _selectAllClicked: function(checkCategories) 107 { 109 108 var childNodes = this._categoriesElement.childNodes; 110 109 for (var i = 0, length = childNodes.length; i < length; ++i) 111 childNodes[i].firstChild.checked = shouldCheckCategoriesOn;112 this._currentCategoriesCount = shouldCheckCategoriesOn? this._totalCategoriesCount : 0;110 childNodes[i].firstChild.checked = checkCategories; 111 this._currentCategoriesCount = checkCategories ? this._totalCategoriesCount : 0; 113 112 this._updateButton(); 114 113 }, … … 130 129 element.type = "checkbox"; 131 130 labelElement.appendChild(element); 132 133 131 labelElement.appendChild(document.createTextNode(title)); 134 132 … … 142 140 this._contentElement.appendChild(this._headerElement); 143 141 142 function handleSelectAllClick(event) 143 { 144 this._selectAllClicked(event.target.checked); 145 } 144 146 var categoryElement = this._createCategoryElement(WebInspector.UIString("Select All"), ""); 145 147 categoryElement.id = "audit-launcher-selectall"; 146 148 this._selectAllCheckboxElement = categoryElement.firstChild; 147 this._selectAllCheckboxElement.addEventListener("click", this._selectAllClicked.bind(this), false); 149 this._selectAllCheckboxElement.checked = true; 150 this._selectAllCheckboxElement.addEventListener("click", handleSelectAllClick.bind(this), false); 148 151 this._contentElement.appendChild(categoryElement); 149 152 … … 192 195 this._contentElement.appendChild(this._buttonContainerElement); 193 196 197 this._selectAllClicked(this._selectAllCheckboxElement.checked); 194 198 this.updateResourceTrackingState(); 195 199 this._updateButton(); -
trunk/WebCore/inspector/front-end/AuditResultView.js
r52558 r52629 33 33 WebInspector.View.call(this); 34 34 35 this.element.addStyleClass("audit-result-view"); 36 37 this.resultBarElement = document.createElement("div"); 38 this.resultBarElement.id = "audit-resultbar"; 39 this.element.appendChild(this.resultBarElement); 35 this.element.id = "audit-result-view"; 40 36 41 37 function entrySortFunction(a, b) … … 51 47 if (entries) { 52 48 entries.sort(entrySortFunction); 53 this. resultBarElement.appendChild(new WebInspector.AuditCategoryResultPane(categoryResults[i]).element);49 this.element.appendChild(new WebInspector.AuditCategoryResultPane(categoryResults[i]).element); 54 50 } 55 51 } … … 80 76 for (var i = 0; i < ruleResult.children.length; ++i) { 81 77 var section = new WebInspector.AuditRuleResultChildSection(ruleResult.children[i]); 82 section.expand();83 78 this.bodyElement.appendChild(section.element); 84 79 } -
trunk/WebCore/inspector/front-end/audits.css
r52558 r52629 51 51 } 52 52 53 .audit-result-view {53 #audit-result-view { 54 54 display: none; 55 55 overflow: auto; … … 59 59 right: 0; 60 60 bottom: 0; 61 }62 63 .audit-result-view.visible {64 display: block;65 }66 67 #audit-resultbar {68 position: absolute;69 top: 0;70 right: 0;71 bottom: 0;72 width: 100%;73 61 background-color: rgb(245, 245, 245); 74 border-left: 1px solid rgb(64%, 64%, 64%);75 62 cursor: default; 76 63 overflow: auto; 77 64 } 78 65 79 #audit-resultbar > .pane img.score { 66 #audit-result-view.visible { 67 display: block; 68 } 69 70 #audit-result-view > .pane img.score { 80 71 float: left; 81 72 margin-top: 2px; … … 86 77 } 87 78 88 #audit-result bar> .pane img.score.red {79 #audit-result-view > .pane img.score.red { 89 80 content: url(Images/errorRedDot.png); 90 81 } 91 82 92 #audit-result bar> .pane img.score.green {83 #audit-result-view > .pane img.score.green { 93 84 content: url(Images/successGreenDot.png); 94 85 } 95 86 96 #audit-resultbar > .pane > .body > .pane:nth-of-type(2n) { 97 background-color: rgba(0, 0, 0, 0.05); 98 } 99 100 #audit-resultbar > .pane > .body > .pane > .title { 87 #audit-result-view > .pane.expanded:nth-last-of-type(1) { 88 border-bottom: 1px solid rgb(189, 189, 189) !important; 89 } 90 91 #audit-result-view .pane.expanded:nth-last-of-type(1) { 92 border-bottom: 0px transparent none; 93 } 94 95 #audit-result-view > .pane > .body > .pane > .title { 101 96 padding-left: 16px; 102 97 background-image: none; … … 104 99 } 105 100 106 #audit-result bar> .pane > .body > .pane > .body {101 #audit-result-view > .pane > .body > .pane > .body { 107 102 background-color: transparent; 108 103 } 109 104 110 #audit-result bar> .pane > .body > .pane .section {105 #audit-result-view > .pane > .body > .pane .section { 111 106 margin-left: 16px; 112 107 } 113 108 114 #audit-result bar.section .header {109 #audit-result-view .section .header { 115 110 border: 0; 116 111 background-image: none; … … 118 113 } 119 114 120 #audit-result bar.section .header > .title {115 #audit-result-view .section .header > .title { 121 116 color: rgb(0, 0, 0); 122 117 } 123 118 124 #audit-result bar.section .section-content {119 #audit-result-view .section .section-content { 125 120 width: 100%; 126 121 padding-left: 18px; … … 128 123 } 129 124 130 #audit-result bar.section.expanded .section-content {131 display: block; 132 } 133 134 #audit-result bar.section.expanded .section-content > p:nth-of-type(1) {125 #audit-result-view .section.expanded .section-content { 126 display: block; 127 } 128 129 #audit-result-view .section.expanded .section-content > p:nth-of-type(1) { 135 130 margin-top: 0; 136 131 } 137 132 138 #audit-result bar.section.expanded .section-content > p:nth-of-type(1) > *:nth-child(1) {133 #audit-result-view .section.expanded .section-content > p:nth-of-type(1) > *:nth-child(1) { 139 134 margin-top: 0; 140 135 } 141 136 142 #audit-result bar.section .header::before {137 #audit-result-view .section .header::before { 143 138 content: url(Images/treeRightTriangleBlack.png); 144 139 } 145 140 146 #audit-result bar.section.expanded .header::before {141 #audit-result-view .section.expanded .header::before { 147 142 content: url(Images/treeDownTriangleBlack.png); 148 143 }
Note: See TracChangeset
for help on using the changeset viewer.