Changeset 52639 in webkit


Ignore:
Timestamp:
Dec 29, 2009 8:12:07 PM (14 years ago)
Author:
eric@webkit.org
Message:

2009-12-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] post-diff requires reading to the end
https://bugs.webkit.org/show_bug.cgi?id=33036

Catch the IOError caused by not reading to the end of the diff. We
don't have a good way to test this currently.

  • Scripts/modules/user.py:
Location:
trunk/WebKitTools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r52636 r52639  
     12009-12-29  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [bzt] post-diff requires reading to the end
     6        https://bugs.webkit.org/show_bug.cgi?id=33036
     7
     8        Catch the IOError caused by not reading to the end of the diff.  We
     9        don't have a good way to test this currently.
     10
     11        * Scripts/modules/user.py:
     12
    1132009-12-29  Chang Shu  <Chang.Shu@nokia.com>
    214
  • trunk/WebKitTools/Scripts/modules/user.py

    r52599 r52639  
    4040    def page(self, message):
    4141        pager = os.environ.get("PAGER") or "less"
    42         child_process = subprocess.Popen([pager], stdin=subprocess.PIPE)
    43         child_process.communicate(input=message)
     42        try:
     43            child_process = subprocess.Popen([pager], stdin=subprocess.PIPE)
     44            child_process.communicate(input=message)
     45        except IOError, e:
     46            pass
    4447
    4548    def confirm(self):
Note: See TracChangeset for help on using the changeset viewer.