Changeset 52660 in webkit

Timestamp:

Dec 30, 2009 6:58:29 AM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-30 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Fix PluginView::handlePostReadFile().
​https://bugs.webkit.org/show_bug.cgi?id=33052

The function should actually rewrite the given file to the buffer.

This change fixes http/tests/plugins/post-url-file.html, which can be unskipped
now along with other passing http/plugins tests.

• plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::handlePostReadFile):

2009-12-30 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Fix PluginView::handlePostReadFile().
​https://bugs.webkit.org/show_bug.cgi?id=33052

The function should actually rewrite the given file to the buffer.

This change fixes http/tests/plugins/post-url-file.html, which can be unskipped
now along with other passing http/plugins tests.

• platform/qt/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/qt/Skipped (modified) (2 diffs)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/plugins/qt/PluginViewQt.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-12-30  Jakub Wieczorek  <faw217@gmail.com>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] Fix PluginView::handlePostReadFile().
+        https://bugs.webkit.org/show_bug.cgi?id=33052
+
+        The function should actually rewrite the given file to the buffer.
+
+        This change fixes http/tests/plugins/post-url-file.html, which can be unskipped
+        now along with other passing http/plugins tests.
+
+        * platform/qt/Skipped:
+
 2009-12-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 

trunk/LayoutTests/platform/qt/Skipped

@@ -22 +22 @@
 http/tests/incremental
 http/tests/media
-http/tests/plugins
 http/tests/webarchive
 http/tests/wml
@@ -35 +34 @@
 http/tests/loading/simple-subframe.html
 http/tests/loading/text-content-type-with-binary-extension.html
+
+# Failing plugins tests
+http/tests/plugins/npapi-response-headers.html
 
 # Failing Local tests

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-30  Jakub Wieczorek  <faw217@gmail.com>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] Fix PluginView::handlePostReadFile().
+        https://bugs.webkit.org/show_bug.cgi?id=33052
+
+        The function should actually rewrite the given file to the buffer.
+
+        This change fixes http/tests/plugins/post-url-file.html, which can be unskipped
+        now along with other passing http/plugins tests.
+
+        * plugins/qt/PluginViewQt.cpp:
+        (WebCore::PluginView::handlePostReadFile):
+
 2009-12-30  Holger Hans Peter Freyther  <zecke@selfish.org>
 

trunk/WebCore/plugins/qt/PluginViewQt.cpp

@@ -530 +530 @@
         filename = filename.substring(8);
 
-    if (!fileExists(filename))
+    long long size;
+    if (!getFileSize(filename, size))
         return NPERR_FILE_NOT_FOUND;
 
-    // FIXME - read the file data into buffer
     FILE* fileHandle = fopen((filename.utf8()).data(), "r");
-
     if (!fileHandle)
         return NPERR_FILE_NOT_FOUND;
 
-    //buffer.resize();
-
-    int bytesRead = fread(buffer.data(), 1, 0, fileHandle);
+    buffer.resize(size);
+    int bytesRead = fread(buffer.data(), 1, size, fileHandle);
 
     fclose(fileHandle);