Changeset 52667 in webkit


Ignore:
Timestamp:
Dec 30, 2009 10:37:32 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-12-30 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

logging.py should be renamed to webkit_logging.py and eventually die
​https://bugs.webkit.org/show_bug.cgi?id=33058

Change all imports of "logging" to webkit_logging,
except the ones which came from Google's cpp_lint.py and diff_parser.py
which clearly are assuming python's logging.py.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/buildbot.py:
  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
  • Scripts/modules/commands/queries.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/commands/upload.py:
  • Scripts/modules/credentials.py:
  • Scripts/modules/executive.py:
  • Scripts/modules/multicommandtool.py:
  • Scripts/modules/queueengine.py:
  • Scripts/modules/scm.py:
  • Scripts/modules/statusbot.py:
  • Scripts/modules/stepsequence.py:
  • Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py.
  • Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py.
Location:
trunk/WebKitTools
Files:
16 edited
2 moved

Legend:

Unmodified
Added
Removed

  • trunk/WebKitTools/ChangeLog

    r52659 r52667  
     12009-12-30  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        logging.py should be renamed to webkit_logging.py and eventually die
     6        https://bugs.webkit.org/show_bug.cgi?id=33058
     7
     8        Change all imports of "logging" to webkit_logging,
     9        except the ones which came from Google's cpp_lint.py and diff_parser.py
     10        which clearly are assuming python's logging.py.
     11
     12        * Scripts/modules/bugzilla.py:
     13        * Scripts/modules/buildbot.py:
     14        * Scripts/modules/buildsteps.py:
     15        * Scripts/modules/commands/download.py:
     16        * Scripts/modules/commands/queries.py:
     17        * Scripts/modules/commands/queues.py:
     18        * Scripts/modules/commands/upload.py:
     19        * Scripts/modules/credentials.py:
     20        * Scripts/modules/executive.py:
     21        * Scripts/modules/multicommandtool.py:
     22        * Scripts/modules/queueengine.py:
     23        * Scripts/modules/scm.py:
     24        * Scripts/modules/statusbot.py:
     25        * Scripts/modules/stepsequence.py:
     26        * Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py.
     27        * Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py.
     28
    1292009-12-30  Jakub Wieczorek  <faw217@gmail.com>
    230

  • trunk/WebKitTools/Scripts/bugzilla-tool

    r52543 r52667  
    4141from modules.commands.upload import *
    4242from modules.executive import Executive
    43 from modules.logging import log
     43from modules.webkit_logging import log
    4444from modules.multicommandtool import MultiCommandTool
    4545from modules.scm import detect_scm_system

  • trunk/WebKitTools/Scripts/modules/bugzilla.py

    r52645 r52667  
    3636
    3737# Import WebKit-specific modules.
    38 from modules.logging import error, log
     38from modules.webkit_logging import error, log
    3939from modules.committers import CommitterList
    4040from modules.credentials import Credentials

  • trunk/WebKitTools/Scripts/modules/buildbot.py

    r51287 r52667  
    3333
    3434# Import WebKit-specific modules.
    35 from modules.logging import log
     35from modules.webkit_logging import log
    3636
    3737# WebKit includes a built copy of BeautifulSoup in Scripts/modules

  • trunk/WebKitTools/Scripts/modules/buildsteps.py

    r52640 r52667  
    3434from modules.comments import bug_comment_from_commit_text
    3535from modules.grammar import pluralize
    36 from modules.logging import log, error
     36from modules.webkit_logging import log, error
    3737from modules.webkitport import WebKitPort
    3838from modules.changelogs import ChangeLog

  • trunk/WebKitTools/Scripts/modules/commands/download.py

    r52641 r52667  
    4040from modules.executive import ScriptError
    4141from modules.grammar import pluralize
    42 from modules.logging import error, log
     42from modules.webkit_logging import error, log
    4343from modules.multicommandtool import AbstractDeclarativeCommmand, Command
    4444from modules.stepsequence import StepSequence

  • trunk/WebKitTools/Scripts/modules/commands/queries.py

    r52645 r52667  
    3434from modules.buildbot import BuildBot
    3535from modules.committers import CommitterList
    36 from modules.logging import log
     36from modules.webkit_logging import log
    3737from modules.multicommandtool import Command
    3838

  • trunk/WebKitTools/Scripts/modules/commands/queues.py

    r52645 r52667  
    3737from modules.executive import ScriptError
    3838from modules.grammar import pluralize
    39 from modules.logging import error, log
     39from modules.webkit_logging import error, log
    4040from modules.multicommandtool import Command
    4141from modules.patchcollection import PersistentPatchCollection, PersistentPatchCollectionDelegate

  • trunk/WebKitTools/Scripts/modules/commands/upload.py

    r52645 r52667  
    4242from modules.committers import CommitterList
    4343from modules.grammar import pluralize
    44 from modules.logging import error, log
     44from modules.webkit_logging import error, log
    4545from modules.multicommandtool import Command, AbstractDeclarativeCommmand
    4646

  • trunk/WebKitTools/Scripts/modules/credentials.py

    r52643 r52667  
    3636
    3737from modules.executive import Executive
    38 from modules.logging import log
     38from modules.webkit_logging import log
    3939from modules.scm import Git
    4040

  • trunk/WebKitTools/Scripts/modules/executive.py

    r52587 r52667  
    3333import sys
    3434
    35 from modules.logging import tee
     35from modules.webkit_logging import tee
    3636
    3737

  • trunk/WebKitTools/Scripts/modules/multicommandtool.py

    r52641 r52667  
    3737
    3838from modules.grammar import pluralize
    39 from modules.logging import log
     39from modules.webkit_logging import log
    4040
    4141

  • trunk/WebKitTools/Scripts/modules/queueengine.py

    r52430 r52667  
    3636
    3737from modules.executive import ScriptError
    38 from modules.logging import log, OutputTee
     38from modules.webkit_logging import log, OutputTee
    3939from modules.statusbot import StatusBot
    4040

  • trunk/WebKitTools/Scripts/modules/scm.py

    r51969 r52667  
    3737from modules.changelogs import ChangeLog
    3838from modules.executive import Executive, run_command, ScriptError
    39 from modules.logging import error, log
     39from modules.webkit_logging import error, log
    4040
    4141def detect_scm_system(path):

  • trunk/WebKitTools/Scripts/modules/statusbot.py

    r52228 r52667  
    2929# WebKit's Python module for interacting with the Commit Queue status page.
    3030
    31 from modules.logging import log
     31from modules.webkit_logging import log
    3232from modules.webkit_mechanize import Browser
    3333

  • trunk/WebKitTools/Scripts/modules/stepsequence.py

    r52378 r52667  
    2929from modules.buildsteps import CommandOptions
    3030from modules.executive import ScriptError
    31 from modules.logging import log
     31from modules.webkit_logging import log
    3232from modules.scm import CheckoutNeedsUpdate
    3333from modules.queueengine import QueueEngine

  • trunk/WebKitTools/Scripts/modules/webkit_logging.py

    r52666 r52667  
    2929#
    3030# WebKit's Python module for logging
     31# This module is now deprecated in favor of python's built-in logging.py.
    3132
    3233import os

  • trunk/WebKitTools/Scripts/modules/webkit_logging_unittest.py

    r52666 r52667  
    3434
    3535from modules.executive import ScriptError
    36 from modules.logging import *
     36from modules.webkit_logging import *
    3737
    3838class LoggingTest(unittest.TestCase):
Note: See TracChangeset for help on using the changeset viewer.