Changeset 52695 in webkit

Timestamp:

Jan 3, 2010 6:03:01 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement mac-ews
​https://bugs.webkit.org/show_bug.cgi?id=33072

The mac-ews is slightly different than the other early warning systems
because we can't run Mac OS X inside a VM. For that reason, we only
process patches that were uploaded by committers. This isn't as much
coverage as the other EWS bots, but it's better than nothing.

• Scripts/modules/commands/early_warning_system.py:
• Scripts/modules/commands/early_warning_system_unittest.py:
• Scripts/modules/commands/queues.py:
• Scripts/modules/commands/queuestest.py:
• Scripts/modules/mock_bugzillatool.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/modules/commands/early_warning_system.py (modified) (2 diffs)
• Scripts/modules/commands/early_warning_system_unittest.py (modified) (1 diff)
• Scripts/modules/commands/queues.py (modified) (1 diff)
• Scripts/modules/commands/queuestest.py (modified) (1 diff)
• Scripts/modules/mock_bugzillatool.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-01-03  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Implement mac-ews
+        https://bugs.webkit.org/show_bug.cgi?id=33072
+
+        The mac-ews is slightly different than the other early warning systems
+        because we can't run Mac OS X inside a VM.  For that reason, we only
+        process patches that were uploaded by committers.  This isn't as much
+        coverage as the other EWS bots, but it's better than nothing.
+
+        * Scripts/modules/commands/early_warning_system.py:
+        * Scripts/modules/commands/early_warning_system_unittest.py:
+        * Scripts/modules/commands/queues.py:
+        * Scripts/modules/commands/queuestest.py:
+        * Scripts/modules/mock_bugzillatool.py:
+
 2010-01-03  Chris Jerdonek  <chris.jerdonek@gmail.com>
 

trunk/WebKitTools/Scripts/modules/commands/early_warning_system.py

@@ -31 +31 @@
 
 from modules.commands.queues import AbstractReviewQueue
+from modules.committers import CommitterList
 from modules.executive import ScriptError
 from modules.webkitport import WebKitPort
@@ -92 +93 @@
         "dglazkov@chromium.org",
     ]
+
+
+# For platforms that we can't run inside a VM (like Mac OS X), we require
+# patches to be uploaded by committers, who are generally trustworthy folk. :)
+class AbstractCommitterOnlyEWS(AbstractEarlyWarningSystem):
+    def __init__(self, committers=CommitterList()):
+        AbstractEarlyWarningSystem.__init__(self)
+        self._committers = committers
+
+    def process_work_item(self, patch):
+        if not self._committers.committer_by_email(patch["attacher_email"]):
+            self._did_error(patch, "%s cannot process patches from non-committers :(" % self.name)
+            return
+        AbstractEarlyWarningSystem.process_work_item(self, patch)
+
+
+class MacEWS(AbstractCommitterOnlyEWS):
+    name = "mac-ews"
+    port_name = "mac"

trunk/WebKitTools/Scripts/modules/commands/early_warning_system_unittest.py

@@ -55 +55 @@
         }
         self.assert_queue_outputs(GtkEWS(), expected_stderr=expected_stderr)
+
+    def test_mac_ews(self):
+        expected_stderr = {
+            "begin_work_queue" : "CAUTION: mac-ews will discard all local changes in \"%s\"\nRunning WebKit mac-ews.\n" % os.getcwd(),
+            "handle_unexpected_error" : "Mock error message\n",
+        }
+        self.assert_queue_outputs(MacEWS(), expected_stderr=expected_stderr)

trunk/WebKitTools/Scripts/modules/commands/queues.py

@@ -74 +74 @@
         self._update_status(self._fail_status, patch)
 
+    def _did_error(self, patch, reason):
+        message = "%s: %s" % (self._error_status, reason)
+        self._update_status(message, patch)
+
     def queue_log_path(self):
         return "%s.log" % self.name

trunk/WebKitTools/Scripts/modules/commands/queuestest.py

@@ -46 +46 @@
         "id" : 1234,
         "bug_id" : 345,
+        "attacher_email": "adam@example.com",
     }
 

trunk/WebKitTools/Scripts/modules/mock_bugzillatool.py

@@ -39 +39 @@
     return dictionary
 
-# FIXME: The ids shoudl be 1, 2, 3 instead of crazy numbers.
+# FIXME: The ids should be 1, 2, 3 instead of crazy numbers.
 _patch1 = {
     "id" : 197,