Changeset 52699 in webkit


Ignore:
Timestamp:
Jan 3, 2010 6:32:06 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-01-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Implement CookieJarChromium::cookiesEnabled
​https://bugs.webkit.org/show_bug.cgi?id=33123

Call out to ChromiumBridge to find out if cookies are enabled.

  • platform/chromium/ChromiumBridge.h:
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::cookiesEnabled):

2010-01-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Implement CookieJarChromium::cookiesEnabled
​https://bugs.webkit.org/show_bug.cgi?id=33123

Call out to the webKitClient() to see if cookies are enabled. Also
remove some straggling references to policyURL!

  • public/WebKitClient.h: (WebKit::WebKitClient::setCookies): (WebKit::WebKitClient::cookies): (WebKit::WebKitClient::rawCookies): (WebKit::WebKitClient::cookiesEnabled):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::cookiesEnabled):
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r52698 r52699  
     12010-01-03  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [Chromium] Implement CookieJarChromium::cookiesEnabled
     6        https://bugs.webkit.org/show_bug.cgi?id=33123
     7
     8        Call out to ChromiumBridge to find out if cookies are enabled.
     9
     10        * platform/chromium/ChromiumBridge.h:
     11        * platform/network/chromium/CookieJarChromium.cpp:
     12        (WebCore::cookiesEnabled):
     13
    1142010-01-03  Adam Barth  <abarth@webkit.org>
    215

  • trunk/WebCore/platform/chromium/ChromiumBridge.h

    r50928 r52699  
    8888        static bool rawCookies(const KURL& url, const KURL& firstPartyForCookies, Vector<Cookie>*);
    8989        static void deleteCookie(const KURL& url, const String& cookieName);
     90        static bool cookiesEnabled(const KURL& url, const KURL& firstPartyForCookies);
    9091
    9192        // DNS ----------------------------------------------------------------

  • trunk/WebCore/platform/network/chromium/CookieJarChromium.cpp

    r50328 r52699  
    4848}
    4949
    50 bool cookiesEnabled(const Document*)
     50bool cookiesEnabled(const Document* document)
    5151{
    52     // FIXME: For now just assume cookies are always on.
    53     return true;
     52    return ChromiumBridge::cookiesEnabled(document->cookieURL(), document->firstPartyForCookies());
    5453}
    5554

  • trunk/WebKit/chromium/ChangeLog

    r52698 r52699  
     12010-01-03  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [Chromium] Implement CookieJarChromium::cookiesEnabled
     6        https://bugs.webkit.org/show_bug.cgi?id=33123
     7
     8        Call out to the webKitClient() to see if cookies are enabled.  Also
     9        remove some straggling references to policyURL!
     10
     11        * public/WebKitClient.h:
     12        (WebKit::WebKitClient::setCookies):
     13        (WebKit::WebKitClient::cookies):
     14        (WebKit::WebKitClient::rawCookies):
     15        (WebKit::WebKitClient::cookiesEnabled):
     16        * src/ChromiumBridge.cpp:
     17        (WebCore::ChromiumBridge::cookiesEnabled):
     18
    1192010-01-03  Adam Barth  <abarth@webkit.org>
    220

  • trunk/WebKit/chromium/public/WebKitClient.h

    r51345 r52699  
    179179
    180180    virtual void setCookies(
    181         const WebURL& url, const WebURL& policyURL, const WebString& cookies) { }
    182     virtual WebString cookies(const WebURL& url, const WebURL& policyURL) { return WebString(); }
    183     virtual bool rawCookies(const WebURL& url, const WebURL& policyURL, WebVector<WebCookie>*) { return false; }
     181        const WebURL& url, const WebURL& firstPartyForCookies, const WebString& cookies) { }
     182    virtual WebString cookies(const WebURL& url, const WebURL& firstPartyForCookies) { return WebString(); }
     183    virtual bool rawCookies(const WebURL& url, const WebURL& firstPartyForCookies, WebVector<WebCookie>*) { return false; }
    184184    virtual void deleteCookie(const WebURL& url, const WebString& cookieName) { }
     185    virtual bool cookiesEnabled(const WebURL& url, const WebURL& firstPartyForCookies) { return true; }
    185186
    186187    // A suggestion to prefetch IP information for the given hostname.

  • trunk/WebKit/chromium/src/ChromiumBridge.cpp

    r52321 r52699  
    214214}
    215215
     216bool ChromiumBridge::cookiesEnabled(const KURL& url,
     217                                    const KURL& firstPartyForCookies)
     218{
     219    return webKitClient()->cookiesEnabled(url, firstPartyForCookies);
     220}
     221
    216222// DNS ------------------------------------------------------------------------
    217223
Note: See TracChangeset for help on using the changeset viewer.