Changeset 52710 in webkit


Ignore:
Timestamp:
Jan 4, 2010 12:30:15 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-01-04 Daniel Bates <​dbates@webkit.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=33039

[bzt] Second attempt to fix an issue where bugzilla-tool dies
when the keychain lookup fails to find an entry for bugs.webkit.org.

  • Scripts/webkitpy/credentials.py:
  • Scripts/webkitpy/credentials_unittest.py:
Location:
trunk/WebKitTools
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKitTools/ChangeLog

    r52708 r52710  
    1010        * Scripts/webkitpy/credentials.py:
    1111        * Scripts/webkitpy/credentials_unittest.py:
     12
     132010-01-04  Eric Seidel  <eric@webkit.org>
     14
     15        Reviewed by Adam Barth.
     16
     17        Make Rollout an AbstractSequencedCommmand
     18        https://bugs.webkit.org/show_bug.cgi?id=33133
     19
     20        As suggested by Adam in:
     21        https://bugs.webkit.org/show_bug.cgi?id=33131#c2
     22
     23        * Scripts/webkitpy/commands/download.py:
    1224
    13252010-01-04  Eric Seidel  <eric@webkit.org>

  • trunk/WebKitTools/Scripts/webkitpy/commands/download.py

    r52707 r52710  
    245245
    246246
    247 # FIXME: Make Rollout more declarative.
    248 class Rollout(AbstractDeclarativeCommmand):
     247class Rollout(AbstractSequencedCommmand):
    249248    name = "rollout"
    250249    show_in_main_help = True
    251250    help_text = "Revert the given revision in the working copy and optionally commit the revert and re-open the original bug"
    252251    argument_names = "REVISION [BUGID]"
    253     def __init__(self):
    254         self._sequence = StepSequence([
    255             CleanWorkingDirectoryStep,
    256             UpdateStep,
    257             RevertRevisionStep,
    258             PrepareChangeLogForRevertStep,
    259             CompleteRollout,
    260         ])
    261         AbstractDeclarativeCommmand.__init__(self, self._sequence.options())
     252    steps = [
     253        CleanWorkingDirectoryStep,
     254        UpdateStep,
     255        RevertRevisionStep,
     256        PrepareChangeLogForRevertStep,
     257        CompleteRollout,
     258    ]
    262259
    263260    @staticmethod
Note: See TracChangeset for help on using the changeset viewer.