Changeset 52716 in webkit


Ignore:
Timestamp:
Jan 4, 2010 1:30:11 AM (14 years ago)
Author:
abarth@webkit.org
Message:

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename StatusBot to StatusServer
https://bugs.webkit.org/show_bug.cgi?id=33139

It's not a bot. It's a server.

  • Scripts/bugzilla-tool:
  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/queueengine.py:
  • Scripts/webkitpy/statusbot.py: Removed.
Location:
trunk/WebKitTools
Files:
7 edited
1 moved

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r52715 r52716  
     12010-01-04  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Rename StatusBot to StatusServer
     6        https://bugs.webkit.org/show_bug.cgi?id=33139
     7
     8        It's not a bot.  It's a server.
     9
     10        * Scripts/bugzilla-tool:
     11        * Scripts/webkitpy/bugzilla.py:
     12        * Scripts/webkitpy/commands/early_warning_system.py:
     13        * Scripts/webkitpy/commands/queues.py:
     14        * Scripts/webkitpy/mock_bugzillatool.py:
     15        * Scripts/webkitpy/queueengine.py:
     16        * Scripts/webkitpy/statusbot.py: Removed.
     17
    1182010-01-04  Adam Barth  <abarth@webkit.org>
    219
  • trunk/WebKitTools/Scripts/bugzilla-tool

    r52703 r52716  
    6161        self.user = User()
    6262        self._scm = None
    63         self.status_bot = StatusBot()
     63        self.status_server = StatusServer()
    6464
    6565    def scm(self):
     
    9696            self.bugs.dryrun = True
    9797        if options.status_host:
    98             self.status_bot.set_host(options.status_host)
     98            self.status_server.set_host(options.status_host)
    9999
    100100    def should_execute_command(self, command):
  • trunk/WebKitTools/Scripts/webkitpy/bugzilla.py

    r52704 r52716  
    258258        committer_list = "WebKitTools/Scripts/webkitpy/committers.py" # This could be computed from CommitterList.__file__
    259259        contribution_guidlines_url = "http://webkit.org/coding/contributing.html" # Should come from some webkit_config.py
    260         queue_administrator = "eseidel@chromium.org" # This could be queried from the status_bot.
     260        queue_administrator = "eseidel@chromium.org" # This could be queried from the status_server.
    261261        queue_name = "commit-queue" # This could be queried from the tool.
    262262        rejection_message = "%s does not have %s permissions according to %s." % (setter_email, flag_name, self._view_source_link(committer_list))
  • trunk/WebKitTools/Scripts/webkitpy/commands/early_warning_system.py

    r52703 r52716  
    7272        if not script_error.command_name() == "build-webkit":
    7373            return
    74         results_link = tool.status_bot.results_url_for_status(status_id)
     74        results_link = tool.status_server.results_url_for_status(status_id)
    7575        message = "Attachment %s did not build on %s:\nBuild output: %s" % (state["patch"]["id"], cls.port_name, results_link)
    7676        tool.bugs.post_comment_to_bug(state["patch"]["bug_id"], message, cc=cls.watchers)
  • trunk/WebKitTools/Scripts/webkitpy/commands/queues.py

    r52703 r52716  
    4040from webkitpy.multicommandtool import Command
    4141from webkitpy.patchcollection import PersistentPatchCollection, PersistentPatchCollectionDelegate
    42 from webkitpy.statusbot import StatusBot
     42from webkitpy.statusserver import StatusServer
    4343from webkitpy.stepsequence import StepSequenceErrorHandler
    4444from webkitpy.queueengine import QueueEngine, QueueEngineDelegate
     
    6666
    6767    def _update_status(self, message, patch=None, results_file=None):
    68         self.tool.status_bot.update_status(self.name, message, patch, results_file)
     68        self.tool.status_server.update_status(self.name, message, patch, results_file)
    6969
    7070    def _did_pass(self, patch):
     
    110110        bugzilla_tool_args = [self.tool.path()]
    111111        # FIXME: This is a hack, we should have a more general way to pass global options.
    112         bugzilla_tool_args += ["--status-host=%s" % self.tool.status_bot.statusbot_host]
     112        bugzilla_tool_args += ["--status-host=%s" % self.tool.status_server.host]
    113113        bugzilla_tool_args += map(str, args)
    114114        self.tool.executive.run_and_throw_if_fail(bugzilla_tool_args)
     
    124124    @classmethod
    125125    def _update_status_for_script_error(cls, tool, state, script_error):
    126         return tool.status_bot.update_status(cls.name, script_error.message, state["patch"], StringIO(script_error.output))
     126        return tool.status_server.update_status(cls.name, script_error.message, state["patch"], StringIO(script_error.output))
    127127
    128128
     
    173173        if not script_error.output:
    174174            return script_error.message_with_output()
    175         results_link = tool.status_bot.results_url_for_status(status_id)
     175        results_link = tool.status_server.results_url_for_status(status_id)
    176176        return "%s\nFull output: %s" % (script_error.message_with_output(), results_link)
    177177
     
    195195
    196196    def status_server(self):
    197         return self.tool.status_bot
     197        return self.tool.status_server
    198198
    199199    # AbstractQueue methods
  • trunk/WebKitTools/Scripts/webkitpy/mock_bugzillatool.py

    r52715 r52716  
    191191
    192192
    193 class MockStatusBot(object):
     193class MockStatusServer(object):
    194194    def __init__(self):
    195         self.statusbot_host = "example.com"
     195        self.host = "example.com"
    196196
    197197    def patch_status(self, queue_name, patch_id):
     
    209209        self.user = MockUser()
    210210        self._scm = MockSCM()
    211         self.status_bot = MockStatusBot()
     211        self.status_server = MockStatusServer()
    212212
    213213    def scm(self):
  • trunk/WebKitTools/Scripts/webkitpy/queueengine.py

    r52703 r52716  
    3737from webkitpy.executive import ScriptError
    3838from webkitpy.webkit_logging import log, OutputTee
    39 from webkitpy.statusbot import StatusBot
     39from webkitpy.statusserver import StatusServer
    4040
    4141class QueueEngineDelegate:
  • trunk/WebKitTools/Scripts/webkitpy/statusserver.py

    r52715 r52716  
    3939
    4040
    41 class StatusBot:
     41class StatusServer:
    4242    default_host = "webkit-commit-queue.appspot.com"
    4343
     
    4747
    4848    def set_host(self, host):
    49         self.statusbot_host = host
    50         self.statusbot_server_url = "http://%s" % self.statusbot_host
     49        self.host = host
     50        self.url = "http://%s" % self.host
    5151
    5252    def results_url_for_status(self, status_id):
    53         return "%s/results/%s" % (self.statusbot_server_url, status_id)
     53        return "%s/results/%s" % (self.url, status_id)
    5454
    5555    def update_status(self, queue_name, status, patch=None, results_file=None):
    56         # During unit testing, statusbot_host is None
    57         if not self.statusbot_host:
     56        # During unit testing, host is None
     57        if not self.host:
    5858            return
    5959
    6060        log(status)
    61         update_status_url = "%s/update-status" % self.statusbot_server_url
     61        update_status_url = "%s/update-status" % self.url
    6262        self.browser.open(update_status_url)
    6363        self.browser.select_form(name="update_status")
     
    7575
    7676    def patch_status(self, queue_name, patch_id):
    77         update_status_url = "%s/patch-status/%s/%s" % (self.statusbot_server_url, queue_name, patch_id)
     77        update_status_url = "%s/patch-status/%s/%s" % (self.url, queue_name, patch_id)
    7878        try:
    7979            return urllib2.urlopen(update_status_url).read()
Note: See TracChangeset for help on using the changeset viewer.