Changeset 52717 in webkit


Ignore:
Timestamp:
Jan 4, 2010 1:33:43 AM (14 years ago)
Author:
abarth@webkit.org
Message:

2010-01-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Move AbstractSequencedCommand to a more general location
​https://bugs.webkit.org/show_bug.cgi?id=33137

I do what the FIXME tell me to do.

  • Scripts/webkitpy/commands/abstractsequencedcommand.py: Added.
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/upload.py:
Location:
trunk/WebKitTools
Files:
1 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKitTools/ChangeLog

    r52716 r52717  
     12010-01-04  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [bzt] Move AbstractSequencedCommand to a more general location
     6        https://bugs.webkit.org/show_bug.cgi?id=33137
     7
     8        I do what the FIXME tell me to do.
     9
     10        * Scripts/webkitpy/commands/abstractsequencedcommand.py: Added.
     11        * Scripts/webkitpy/commands/download.py:
     12        * Scripts/webkitpy/commands/upload.py:
     13
    1142010-01-04  Adam Barth  <abarth@webkit.org>
    215

  • trunk/WebKitTools/Scripts/webkitpy/commands/download.py

    r52714 r52717  
    1 #!/usr/bin/env python
    21# Copyright (c) 2009, Google Inc. All rights reserved.
    32# Copyright (c) 2009 Apple Inc. All rights reserved.
    … …  
    3837# We could instead use from modules import buildsteps and then prefix every buildstep with "buildsteps."
    3938from webkitpy.changelogs import ChangeLog
     39from webkitpy.commands.abstractsequencedcommand import AbstractSequencedCommmand
    4040from webkitpy.comments import bug_comment_from_commit_text
    4141from webkitpy.executive import ScriptError
    … …  
    4444from webkitpy.multicommandtool import AbstractDeclarativeCommmand
    4545from webkitpy.stepsequence import StepSequence
    46 
    47 
    48 # FIXME: Move this to a more general location.
    49 class AbstractSequencedCommmand(AbstractDeclarativeCommmand):
    50     steps = None
    51     def __init__(self):
    52         self._sequence = StepSequence(self.steps)
    53         AbstractDeclarativeCommmand.__init__(self, self._sequence.options())
    54 
    55     def _prepare_state(self, options, args, tool):
    56         return None
    57 
    58     def execute(self, options, args, tool):
    59         self._sequence.run_and_handle_errors(tool, options, self._prepare_state(options, args, tool))
    6046
    6147

  • trunk/WebKitTools/Scripts/webkitpy/commands/upload.py

    r52714 r52717  
    3939
    4040from webkitpy.bugzilla import parse_bug_id
    41 from webkitpy.commands.download import AbstractSequencedCommmand
     41from webkitpy.commands.abstractsequencedcommand import AbstractSequencedCommmand
    4242from webkitpy.comments import bug_comment_from_svn_revision
    4343from webkitpy.committers import CommitterList
Note: See TracChangeset for help on using the changeset viewer.