Changeset 52881 in webkit


Ignore:
Timestamp:
Jan 6, 2010 4:30:40 PM (14 years ago)
Author:
ojan@chromium.org
Message:

2010-01-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Carlson.

media/video-seeking.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33273

Removed setTimeouts from this test. It kind of looks
like they were intentional, but I don't see how they add
anything to this test (other than race conditions).

  • media/video-seeking-expected.txt:
  • media/video-seeking.html:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r52879 r52881  
     12010-01-06  Ojan Vafai  <ojan@chromium.org>
     2
     3        Reviewed by Eric Carlson.
     4
     5        media/video-seeking.html is flaky
     6        https://bugs.webkit.org/show_bug.cgi?id=33273
     7
     8        Removed setTimeouts from this test. It kind of looks
     9        like they were intentional, but I don't see how they add
     10        anything to this test (other than race conditions).
     11
     12        * media/video-seeking-expected.txt:
     13        * media/video-seeking.html:
     14
    1152010-01-06  Ojan Vafai  <ojan@chromium.org>
    216
  • trunk/LayoutTests/media/video-seeking-expected.txt

    r50063 r52881  
    66EVENT(seeked)
    77
    8 EXPECTED (seekedCount == '1') OK
    98EXPECTED (video.seeking == 'false') OK
    109EXPECTED (video.currentTime == '0.5') OK
     
    1413EVENT(seeked)
    1514
    16 EXPECTED (seekedCount == '2') OK
    1715EXPECTED (video.seeking == 'false') OK
    1816EXPECTED (video.currentTime == '1') OK
     
    2220EVENT(seeked)
    2321
    24 EXPECTED (seekedCount == '3') OK
    2522EXPECTED (video.seeking == 'false') OK
    2623EXPECTED (video.currentTime == '1.5') OK
  • trunk/LayoutTests/media/video-seeking.html

    r50063 r52881  
    99
    1010    var seekedCount = 0;
    11     var counter;
    1211
    1312    function seeked()
     
    1514        ++seekedCount;
    1615        consoleWrite("");
    17     }
    1816
    19     function someTimeLater()
    20     {
    21         testExpected("seekedCount", counter);
    2217        testExpected("video.seeking", false);
    23         testExpected("video.currentTime", counter * 0.5);
    24         run("video.currentTime = " + (counter + 1) * 0.5);
     18        testExpected("video.currentTime", seekedCount * 0.5);
     19        run("video.currentTime = " + (seekedCount + 1) * 0.5);
    2520        testExpected("video.seeking", true);
    2621
    27         if (counter == 3)
    28         {
    29             consoleWrite("");
     22        consoleWrite("");
     23
     24        if (seekedCount == 3)
    3025            endTest();
    31         }
    32 
    33         ++counter;
    34         consoleWrite("");
    3526     }
    3627
     
    3829    {
    3930        run("video.currentTime = 0.5");
    40         counter = 1;
    41         setTimeout(someTimeLater, 200)
    42         setTimeout(someTimeLater, 400)
    43         setTimeout(someTimeLater, 600)
    4431        consoleWrite("");
    4532    }
Note: See TracChangeset for help on using the changeset viewer.