Changeset 52908 in webkit

Timestamp:

Jan 7, 2010 12:57:10 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
​https://bugs.webkit.org/show_bug.cgi?id=33290

Add the Chromium builders to our list of core builders and test that our regexps work.
I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.

• Scripts/webkitpy/buildbot.py:
• Scripts/webkitpy/buildbot_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/buildbot.py (modified) (1 diff)
• Scripts/webkitpy/buildbot_unittest.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-01-07  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
+        https://bugs.webkit.org/show_bug.cgi?id=33290
+
+        Add the Chromium builders to our list of core builders and test that our regexps work.
+        I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.
+
+        * Scripts/webkitpy/buildbot.py:
+        * Scripts/webkitpy/buildbot_unittest.py:
+
 2010-01-07  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/buildbot.py

@@ -45 +45 @@
         self.buildbot_server_url = "http://%s/" % self.buildbot_host
         
-        # If any of the Leopard build/test bots or the Windows builders are red we should not be landing patches.
-        # Other builders should be added to this list once they're known to be stable.
-        self.core_builder_names_regexps = [ 'Leopard', "Windows.*Build" ]
+        # If any Leopard builder/tester, Windows builder or Chromium builder is red we should not be landing patches.
+        # Other builders should be added to this list once they are known to be reliable.
+        # See https://bugs.webkit.org/show_bug.cgi?id=33296 and related bugs.
+        self.core_builder_names_regexps = [ "Leopard", "Windows.*Build", "Chromium" ]
 
     # If WebKit's buildbot has an XMLRPC interface we could use, we could do something more sophisticated here.

trunk/WebKitTools/Scripts/webkitpy/buildbot_unittest.py

@@ -111 +111 @@
         buildbot = BuildBot()
 
+        # For complete testing, this list should match the list of builders at build.webkit.org:
         example_builders = [
-            { 'name': u'Leopard Debug (Build)', },
-            { 'name': u'Leopard Debug (Tests)', },
+            { 'name': u'Tiger Intel Release', },
+            { 'name': u'Leopard Intel Release (Build)', },
+            { 'name': u'Leopard Intel Release (Tests)', },
+            { 'name': u'Leopard Intel Debug (Build)', },
+            { 'name': u'Leopard Intel Debug (Tests)', },
+            { 'name': u'SnowLeopard Intel Release (Build)', },
+            { 'name': u'SnowLeopard Intel Release (Tests)', },
+            { 'name': u'SnowLeopard Intel Leaks', },
             { 'name': u'Windows Release (Build)', },
+            { 'name': u'Windows Release (Tests)', },
+            { 'name': u'Windows Debug (Build)', },
             { 'name': u'Windows Debug (Tests)', },
             { 'name': u'Qt Linux Release', },
+            { 'name': u'Gtk Linux Release', },
+            { 'name': u'Gtk Linux 32-bit Debug', },
+            { 'name': u'Gtk Linux 64-bit Debug', },
+            { 'name': u'Chromium Linux Release', },
+            { 'name': u'Chromium Mac Release', },
+            { 'name': u'Chromium Win Release', },
         ]
-        name_regexps = [ 'Leopard', "Windows.*Build" ]
+        name_regexps = [ "Leopard", "Windows.*Build", "Chromium" ]
         expected_builders = [
-            { 'name': u'Leopard Debug (Build)', },
-            { 'name': u'Leopard Debug (Tests)', },
+            { 'name': u'Leopard Intel Release (Build)', },
+            { 'name': u'Leopard Intel Release (Tests)', },
+            { 'name': u'Leopard Intel Debug (Build)', },
+            { 'name': u'Leopard Intel Debug (Tests)', },
             { 'name': u'Windows Release (Build)', },
+            { 'name': u'Windows Debug (Build)', },
+            { 'name': u'Chromium Linux Release', },
+            { 'name': u'Chromium Mac Release', },
+            { 'name': u'Chromium Win Release', },
         ]