Changeset 52913 in webkit

Timestamp:

Jan 7, 2010 2:52:04 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-07 Kent Tamura <​tkent@chromium.org>

Reviewed by Adam Barth.

Fix an issue that CodeGeneratorV8.pm doesnt handle HasIndexGetter of
WebKitCSSTransformValue.idl correctly.
​https://bugs.webkit.org/show_bug.cgi?id=33193

CodeGeneratorV8.pm doesn't handle inheritance very well and it
tried to refer v8WebKitCSSTransformValueIndexedPropertyGetter(),
which does not exist. Because WebKitCSSTransformValue inherits
CSSValueList and CSSValueList already has HadIndexGetter, we don't
need to do anything for WebKitCSSTransformValue about HasIndexGetter.

• bindings/scripts/CodeGeneratorV8.pm: Reset $hasGetter for WebKitCSSTransformValue.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorV8.pm (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-01-07  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Fix an issue that CodeGeneratorV8.pm doesnt handle HasIndexGetter of
+        WebKitCSSTransformValue.idl correctly.
+        https://bugs.webkit.org/show_bug.cgi?id=33193
+
+        CodeGeneratorV8.pm doesn't handle inheritance very well and it
+        tried to refer v8WebKitCSSTransformValueIndexedPropertyGetter(),
+        which does not exist. Because WebKitCSSTransformValue inherits
+        CSSValueList and CSSValueList already has HadIndexGetter, we don't
+        need to do anything for WebKitCSSTransformValue about HasIndexGetter.
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+          Reset $hasGetter for WebKitCSSTransformValue.
+
 2010-01-07  Anton Muhin  <antonm@chromium.org>
 

trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -1222 +1222 @@
     if ($interfaceName eq "HTMLOptionsCollection") {
         $hasGetter = 1;
+    }
+    # FIXME: If the parent interface of $dataNode already has
+    # HasIndexGetter, we don't need to handle the getter here.
+    if ($interfaceName eq "WebKitCSSTransformValue") {
+        $hasGetter = 0;
     }