Changeset 52915 in webkit


Ignore:
Timestamp:
Jan 7, 2010 3:35:40 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-01-07 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

Some IDL files lack "," separators for extended attributes.
​https://bugs.webkit.org/show_bug.cgi?id=33190

To find such mistakes, IDLParser.pm rejects whitespace characters in
extended attribute names.

  • bindings/scripts/IDLParser.pm: parseExtendedAttributes rejects whitespace in a name.
  • css/WebKitCSSTransformValue.idl: Add missing ",".
  • dom/EventTarget.idl: ditto.
Location:
trunk/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r52913 r52915  
     12010-01-07  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Some IDL files lack "," separators for extended attributes.
     6        https://bugs.webkit.org/show_bug.cgi?id=33190
     7
     8        To find such mistakes, IDLParser.pm rejects whitespace characters in
     9        extended attribute names.
     10
     11        * bindings/scripts/IDLParser.pm:
     12          parseExtendedAttributes rejects whitespace in a name.
     13        * css/WebKitCSSTransformValue.idl: Add missing ",".
     14        * dom/EventTarget.idl: ditto.
     15
    1162010-01-07  Kent Tamura  <tkent@chromium.org>
    217

  • trunk/WebCore/bindings/scripts/IDLParser.pm

    r50583 r52915  
    159159        $value = 1 unless defined $value;
    160160        $attrs{$name} = $value;
     161        die("Invalid extended attribute name: '$name'\n") if $name =~ /\s/;
    161162    }
    162163

  • trunk/WebCore/css/WebKitCSSTransformValue.idl

    r52537 r52915  
    3030
    3131    interface [
    32             HasIndexGetter
     32            HasIndexGetter,
    3333            InterfaceUUID=303fe632-5dcf-4472-b977-33a5481e1d12,
    3434            ImplementationUUID=eb49e5c6-6075-45b8-b5c4-7e775c01e7c4

  • trunk/WebCore/dom/EventTarget.idl

    r52534 r52915  
    2525        ObjCProtocol,
    2626        PureInterface,
    27         OmitConstructor
     27        OmitConstructor,
    2828        InterfaceUUID=1D71C7EC-0BA0-4044-BDFD-56B3E8F5F9D4
    2929    ] EventTarget {
Note: See TracChangeset for help on using the changeset viewer.