Changeset 52983 in webkit


Ignore:
Timestamp:
Jan 8, 2010 3:32:55 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-01-08 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

Don't store RegExp flags string representation
https://bugs.webkit.org/show_bug.cgi?id=33321

It's unused; the string representation is reconstructed from flags.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp):
  • runtime/RegExp.h:
Location:
trunk/JavaScriptCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/ChangeLog

    r52981 r52983  
     12010-01-08  Kent Hansen  <kent.hansen@nokia.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Don't store RegExp flags string representation
     6        https://bugs.webkit.org/show_bug.cgi?id=33321
     7
     8        It's unused; the string representation is reconstructed from flags.
     9
     10        * runtime/RegExp.cpp:
     11        (JSC::RegExp::RegExp):
     12        * runtime/RegExp.h:
     13
    1142010-01-08  Kent Hansen  <kent.hansen@nokia.com>
    215
  • trunk/JavaScriptCore/runtime/RegExp.cpp

    r45545 r52983  
    6666inline RegExp::RegExp(JSGlobalData* globalData, const UString& pattern, const UString& flags)
    6767    : m_pattern(pattern)
    68     , m_flags(flags)
    6968    , m_flagBits(0)
    7069    , m_constructionError(0)
  • trunk/JavaScriptCore/runtime/RegExp.h

    r45545 r52983  
    5050
    5151        const UString& pattern() const { return m_pattern; }
    52         const UString& flags() const { return m_flags; }
    5352
    5453        bool isValid() const { return !m_constructionError; }
     
    6766
    6867        UString m_pattern; // FIXME: Just decompile m_regExp instead of storing this.
    69         UString m_flags; // FIXME: Just decompile m_regExp instead of storing this.
    7068        int m_flagBits;
    7169        const char* m_constructionError;
Note: See TracChangeset for help on using the changeset viewer.