Changeset 52989 in webkit

Timestamp:

Jan 8, 2010 4:59:05 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-08 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Hausmann.

commit-queue should run run-javascriptcore-tests
​https://bugs.webkit.org/show_bug.cgi?id=33376

I also made it run the python and perl unit tests.

• Scripts/webkitpy/steps/runtests.py:
• Scripts/webkitpy/webkitport.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/steps/runtests.py (modified) (2 diffs)
• Scripts/webkitpy/webkitport.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-01-08  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Simon Hausmann.
+
+        commit-queue should run run-javascriptcore-tests
+        https://bugs.webkit.org/show_bug.cgi?id=33376
+
+        I also made it run the python and perl unit tests.
+
+        * Scripts/webkitpy/steps/runtests.py:
+        * Scripts/webkitpy/webkitport.py:
+
 2010-01-07  Andras Becsi  <abecsi@inf.u-szeged.hu>
 

trunk/WebKitTools/Scripts/webkitpy/steps/runtests.py

@@ -46 +46 @@
         if not self._options.test:
             return
+
+        # Run the scripting unit tests first because they're quickest.
+        self._tool.executive.run_and_throw_if_fail(self.port().run_python_unittests_command())
+        self._tool.executive.run_and_throw_if_fail(self.port().run_perl_unittests_command())
+        self._tool.executive.run_and_throw_if_fail(self.port().run_javascriptcore_tests_command())
+
         args = self.port().run_webkit_tests_command()
         if self._options.non_interactive:
@@ -53 +59 @@
             args.append("--quiet")
         self._tool.executive.run_and_throw_if_fail(args)
+

trunk/WebKitTools/Scripts/webkitpy/webkitport.py

@@ -72 +72 @@
 
     @classmethod
+    def run_javascriptcore_tests_command(cls):
+        return [cls.script_path("run-javascriptcore-tests")]
+
+    @classmethod
     def run_webkit_tests_command(cls):
         return [cls.script_path("run-webkit-tests")]
+
+    @classmethod
+    def run_python_unittests_command(cls):
+        return [cls.script_path("test-webkitpy")]
+
+    @classmethod
+    def run_perl_unittests_command(cls):
+        return [cls.script_path("test-webkitperl")]