Changeset 53009 in webkit


Ignore:
Timestamp:
Jan 8, 2010 2:29:55 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-01-08 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

WebGLArray subclasses do the wrong conversion in indexSetter
​https://bugs.webkit.org/show_bug.cgi?id=33350

  • fast/canvas/webgl/array-setters-expected.txt: Added.
  • fast/canvas/webgl/array-setters.html: Added.
  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

2010-01-08 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

WebGLArray subclasses do the wrong conversion in indexSetter
​https://bugs.webkit.org/show_bug.cgi?id=33350

Test: fast/canvas/webgl/array-setters.html

  • bindings/js/JSWebGLFloatArrayCustom.cpp: (WebCore::JSWebGLFloatArray::indexSetter):
  • bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: (WebCore::JSWebGLUnsignedIntArray::indexSetter):
Location:
trunk
Files:
2 added
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r53006 r53009  
     12010-01-08  Kenneth Russell  <kbr@google.com>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        WebGLArray subclasses do the wrong conversion in indexSetter
     6        https://bugs.webkit.org/show_bug.cgi?id=33350
     7
     8        * fast/canvas/webgl/array-setters-expected.txt: Added.
     9        * fast/canvas/webgl/array-setters.html: Added.
     10        * fast/canvas/webgl/array-unit-tests-expected.txt:
     11        * fast/canvas/webgl/array-unit-tests.html:
     12
    1132010-01-08  Ojan Vafai  <ojan@chromium.org>
    214

  • trunk/LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt

    r51049 r53009  
    2424PASS test WebGLFloatArray Slice
    2525PASS negativeTest WebGLFloatArray Slice
    26 PASS test WebGLFloatArray BoundaryConditions(-500, -500, 500, 500)
     26PASS test WebGLFloatArray BoundaryConditions(-500.5, -500.5, 500.5, 500.5)
    2727PASS test WebGLIntArray SetAndGetPos10ToNeg10
    2828PASS test WebGLIntArray SetAndGetMethodsPos10ToNeg10

  • trunk/LayoutTests/fast/canvas/webgl/array-unit-tests.html

    r52058 r53009  
    367367       unsigned: false,
    368368       elementSizeInBytes: 4,
    369        low: -500,
    370        expectedLow: -500,
    371        high: 500,
    372        expectedHigh: 500},
     369       low: -500.5,
     370       expectedLow: -500.5,
     371       high: 500.5,
     372       expectedHigh: 500.5},
    373373      {name: "WebGLIntArray",
    374374       unsigned: false,

  • trunk/WebCore/ChangeLog

    r53005 r53009  
     12010-01-08  Kenneth Russell  <kbr@google.com>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        WebGLArray subclasses do the wrong conversion in indexSetter
     6        https://bugs.webkit.org/show_bug.cgi?id=33350
     7
     8        Test: fast/canvas/webgl/array-setters.html
     9
     10        * bindings/js/JSWebGLFloatArrayCustom.cpp:
     11        (WebCore::JSWebGLFloatArray::indexSetter):
     12        * bindings/js/JSWebGLUnsignedIntArrayCustom.cpp:
     13        (WebCore::JSWebGLUnsignedIntArray::indexSetter):
     14
    1152010-01-08  Luiz Agostini  <luiz.agostini@openbossa.org>
    216

  • trunk/WebCore/bindings/js/JSWebGLFloatArrayCustom.cpp

    r52058 r53009  
    3939void JSWebGLFloatArray::indexSetter(JSC::ExecState* exec, unsigned index, JSC::JSValue value)
    4040{
    41     impl()->set(index, static_cast<float>(value.toInt32(exec)));
     41    impl()->set(index, static_cast<float>(value.toNumber(exec)));
    4242}
    4343

  • trunk/WebCore/bindings/js/JSWebGLUnsignedIntArrayCustom.cpp

    r52058 r53009  
    3939void JSWebGLUnsignedIntArray::indexSetter(JSC::ExecState* exec, unsigned index, JSC::JSValue value)
    4040{
    41     impl()->set(index, static_cast<unsigned int>(value.toInt32(exec)));
     41    impl()->set(index, static_cast<unsigned int>(value.toUInt32(exec)));
    4242}
    4343
Note: See TracChangeset for help on using the changeset viewer.