Changeset 53044 in webkit


Ignore:
Timestamp:
Jan 9, 2010 4:40:21 PM (14 years ago)
Author:
dbates@webkit.org
Message:

2010-01-09 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=33419

Adds support for the XSSAuditor to the Qt DRT.

  • Api/qwebsettings.cpp: Updated comment to reflect added key XSSAuditorEnabled.
  • Api/qwebsettings.h: Adds settings key XSSAuditorEnabled.

2010-01-09 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=33419

Removes the XSSAuditor tests from the Qt Skipped file since
we now can run these tests.

  • platform/qt/Skipped:

2010-01-09 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=33419

Adds support for the XSSAuditor to the Qt DRT.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r53039 r53044  
     12010-01-09  Daniel Bates  <dbates@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=33419
     6
     7        Removes the XSSAuditor tests from the Qt Skipped file since
     8        we now can run these tests.
     9
     10        * platform/qt/Skipped:
     11
    1122010-01-09  Dan Bernstein  <mitz@apple.com>
    213

  • trunk/LayoutTests/platform/qt/Skipped

    r52902 r53044  
    197197# Missing layoutTestController.setWillSendRequestReturnsNullOnRedirect()
    198198http/tests/misc/will-send-request-returns-null-on-redirect.html
    199 
    200 # Missing layoutTestController.setXSSAuditorEnabled()
    201 http/tests/security/xssAuditor
    202199
    203200# Missing layoutTestController.evaluateScriptInIsolatedWorld()

  • trunk/WebKit/qt/Api/qwebsettings.cpp

    r52928 r53044  
    355355        QWebSettings::LocalStorageEnabled instead.
    356356    \value LocalContentCanAccessRemoteUrls Specifies whether locally loaded documents are allowed to access remote urls.
     357    \value XSSAuditorEnabled Enables or disables WebKit's XSSAuditor to mitigate reflective cross-site scripting attacks.
    357358*/
    358359

  • trunk/WebKit/qt/Api/qwebsettings.h

    r51154 r53044  
    6868#endif
    6969        LocalContentCanAccessRemoteUrls,
    70         DnsPrefetchEnabled
     70        DnsPrefetchEnabled,
     71        XSSAuditorEnabled
    7172    };
    7273    enum WebGraphic {

  • trunk/WebKit/qt/ChangeLog

    r53005 r53044  
     12010-01-09  Daniel Bates  <dbates@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=33419
     6
     7        Adds support for the XSSAuditor to the Qt DRT.
     8
     9        * Api/qwebsettings.cpp: Updated comment to reflect added key XSSAuditorEnabled.
     10        * Api/qwebsettings.h: Adds settings key XSSAuditorEnabled.
     11
    1122010-01-08  Luiz Agostini  <luiz.agostini@openbossa.org>
    213

  • trunk/WebKitTools/ChangeLog

    r53043 r53044  
     12010-01-09  Daniel Bates  <dbates@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=33419
     6
     7        Adds support for the XSSAuditor to the Qt DRT.
     8
     9        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
     10        (WebCore::WebPage::WebPage):
     11        (WebCore::WebPage::resetSettings):
     12        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
     13        (LayoutTestController::setXSSAuditorEnabled):
     14        * DumpRenderTree/qt/LayoutTestControllerQt.h:
     15
    1162010-01-09  Adam Barth  <abarth@webkit.org>
    217

  • trunk/WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp

    r52612 r53044  
    134134    globalSettings->setAttribute(QWebSettings::PrivateBrowsingEnabled, false);
    135135    globalSettings->setAttribute(QWebSettings::OfflineWebApplicationCacheEnabled, false);
     136    globalSettings->setAttribute(QWebSettings::XSSAuditorEnabled, false);
    136137
    137138    connect(this, SIGNAL(geometryChangeRequested(const QRect &)),
    … …  
    168169    settings()->resetAttribute(QWebSettings::OfflineWebApplicationCacheEnabled);
    169170    settings()->resetAttribute(QWebSettings::LocalContentCanAccessRemoteUrls);
     171    settings()->resetAttribute(QWebSettings::XSSAuditorEnabled);
    170172    QWebSettings::setMaximumPagesInCache(0); // reset to default
    171173}

  • trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp

    r52659 r53044  
    277277}
    278278
     279void LayoutTestController::setXSSAuditorEnabled(bool enable)
     280{
     281    m_drt->webPage()->settings()->setAttribute(QWebSettings::XSSAuditorEnabled, enable);
     282}
     283
    279284void LayoutTestController::setPopupBlockingEnabled(bool enable)
    280285{

  • trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.h

    r52611 r53044  
    111111    void setFixedContentsSize(int width, int height);
    112112    void setPrivateBrowsingEnabled(bool enable);
     113    void setXSSAuditorEnabled(bool flag);
    113114    void setPopupBlockingEnabled(bool enable);
    114115    void setPOSIXLocale(const QString& locale);
Note: See TracChangeset for help on using the changeset viewer.