Changeset 53055 in webkit

Timestamp:

Jan 10, 2010 4:38:16 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-10 Adam Barth <​abarth@webkit.org>

Reviewed by Nikolas Zimmermann.

http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
​https://bugs.webkit.org/show_bug.cgi?id=33349

Previously we were using JavaScript URLs to return to the main event
loop, but that is potentially unreliable because there can be only one
scheduled redirect in flight per frame. Let's try using setTimeout
instead. Notice that there isn't a race condition here because the
event loop will always dispatch the actions in the proper order.

• http/tests/security/xss-DENIED-window-open-javascript-url.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/security/xss-DENIED-window-open-javascript-url.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-01-10  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Nikolas Zimmermann.
+
+        http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
+        https://bugs.webkit.org/show_bug.cgi?id=33349
+
+        Previously we were using JavaScript URLs to return to the main event
+        loop, but that is potentially unreliable because there can be only one
+        scheduled redirect in flight per frame.  Let's try using setTimeout
+        instead.  Notice that there isn't a race condition here because the
+        event loop will always dispatch the actions in the proper order.
+
+        * http/tests/security/xss-DENIED-window-open-javascript-url.html:
+
 2010-01-09  Daniel Bates  <dbates@webkit.org>
 

trunk/LayoutTests/http/tests/security/xss-DENIED-window-open-javascript-url.html

@@ -8 +8 @@
 }
 function runTest() {
+    // Schedule a return to the main event loop so that the javascript: URL
+    // has a chance to run.
+    setTimeout(done, 0);
     window.open("javascript:alert('FAIL')", "tg");
-    window.open("javascript:done()", "_self");
 }
 function done() {